Date: Sat, 01 Nov 2014 17:29:11 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 194406] [new port] graphics/code-eli Message-ID: <bug-194406-13-S25Q7HP5DA@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-194406-13@https.bugs.freebsd.org/bugzilla/> References: <bug-194406-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D194406 --- Comment #4 from fernando.apesteguia@gmail.com --- (In reply to John Marino from comment #2) > The log looks good, but I see several issues (or possible issues) with the > shar: >=20 > 1) You used "@" on all your commands in the do-install target. You are o= nly > allowed to mask mkdir commands Done. I'll remember that. >=20 > 2) the clang stuff is hacked > X.if ${OSVERSION} < 1000000 > XBUILD_DEPENDS+=3D clang33:${PORTSDIR}/lang/clang33 > XCC=3D clang33 > XCXX=3D clang++33 > XCPP=3D clang-cpp33 > X.endif > You should not checking OSVERSION, you should be using USES=3Dcompiler:ar= gs.=20 > Even if you did use OSVERSION (you can't) you need to prefix it with > ${OPSYS} =3D=3D FreeBSD since OSVERSION only applies to FreeBSD >=20 I was unaware of the compiler:args option and I saw the hack in another por= t... :) > 3) this line: > XWRKSRC=3D ${WRKDIR}/${GH_ACCOUNT}-${GH_PROJECT}-${GH_COMMIT} > I suspect using GITHUB already properly defines WRKSRC -- please check >=20 Right. Done. > 4) these lines: > XBUILD_DEPENDS+=3D > ${LOCALBASE}/include/eigen3/Eigen/src/Core/Array.h:${PORTSDIR}/math/eigen3 > XBUILD_DEPENDS+=3D ${LOCALBASE}/bin/doxygen:${PORTSDIR}/devel/doxygen >=20 > change to:=20 > XBUILD_DEPENDS=3D > ${LOCALBASE}/include/eigen3/Eigen/src/Core/Array.h:${PORTSDIR}/math/eigen= 3 \ > ${LOCALBASE}/bin/doxygen:${PORTSDIR}/devel/doxygen Done. I thought multilines are not friendly with out makefiles in the port's collection. >=20 > 5) PORTREVISION=3D1 > A new port should never define PORTREVISION. I should be "0" right? >=20 Done. Sorry, I used other of my ports as template and I missed this. > 6) PORTDOCS > Personally I'd like to see you define "PORTDOCS=3D html latex" in the mak= efile > and remove EVERY SINGLE PORTDOCS line from the pkg-plist. You can also > remove the check for PORT_OPTIONS:MDOCS and just install them > unconditionally. (the port will ignore them if the DOCS option is unset)= .=20 > But you can also leave it if the copying of the html and latex is heavy. Done. The pkg-plist is much shorter now. I'd rather leave the conditional though. If I remove the option, I will try= to cd into a directory that doesn't exist yet... >=20 > 7) PORTEXAMPLES > You can also define "PORTEXAMPLES=3D AirfoilFitExample VSPPodExample test= " and > remove these from the pkg-plist too if you want. Done. >=20 > 8) USES > don't define USES+=3D on the first instance, it should be "USES=3D > cmake:outsource" Done. I run the port with port test and it works fine with the 4 combinations of = the options. I attach new shar file(v2) and a new poudriere log(v2) for 10.0-RELEASE-amd= 64. Thanks for the mentoring! --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-194406-13-S25Q7HP5DA>