Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 19 Aug 2018 17:21:59 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 230721] audio/ncmpc: Update to 0.30
Message-ID:  <bug-230721-7788-X3kXJ7XCoH@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-230721-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-230721-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D230721

Tobias Kortkamp <tobik@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tobik@freebsd.org

--- Comment #5 from Tobias Kortkamp <tobik@freebsd.org> ---
Comment on attachment 196349
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D196349
Patch to apply to audio/ncmpc: take over maintainership as well

Hi,

it still needs some work:

- It fails to build on 10.4/i386: https://ptpb.pw/Avo6

- The entire options block could be indented one level less like before

- Why is MAKE_JOBS_UNSAFE=3Dyes needed?

- Man pages need to go into ${PREFIX}/man not ${PREFIX}/share/man

- It is ugly that the MANPAGES option installs files into DOCSDIR.
  Please add a DOCS option.  You can do something like DOCS_IMPLIES=3DMANPA=
GES
  and use %%PORTDOCS%% instead of %%MANPAGES%% in pkg-plist for the files=20
  installed into DOCSDIR.

- Please remove all empty lines from pkg-plist

- Please check portlint -C output

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-230721-7788-X3kXJ7XCoH>