From owner-svn-src-all@freebsd.org Sat Aug 1 05:32:31 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 13C139B16BD; Sat, 1 Aug 2015 05:32:31 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E524116C7; Sat, 1 Aug 2015 05:32:30 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (75-48-78-19.lightspeed.cncrca.sbcglobal.net [75.48.78.19]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id F29B5B97B; Sat, 1 Aug 2015 01:32:29 -0400 (EDT) From: John Baldwin To: "Andrey V. Elsukov" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r285888 - head/sys/kern Date: Fri, 31 Jul 2015 10:54:15 -0700 Message-ID: <1825472.MtINFO9Kkx@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-PRERELEASE; KDE/4.14.3; amd64; ; ) In-Reply-To: <201507261053.t6QArX3q081202@repo.freebsd.org> References: <201507261053.t6QArX3q081202@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Sat, 01 Aug 2015 01:32:30 -0400 (EDT) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Aug 2015 05:32:31 -0000 On Sunday, July 26, 2015 10:53:33 AM Andrey V. Elsukov wrote: > Author: ae > Date: Sun Jul 26 10:53:32 2015 > New Revision: 285888 > URL: https://svnweb.freebsd.org/changeset/base/285888 > > Log: > Build debug version of rmlock's methods only when LOCK_DEBUG > 0. > > Currently LOCK_DEBUG is always defined in sys/lock.h (0 or 1). > This means that debugging code always built. In addition the kernel > modules have always defined LOCK_DEBUG as 1. So, debugging rmlock code > is always used by kernel modules. Debugging versions of locking primitives are always used by all locking primitives (mutexes, rw, sx, etc.) so that if the kernel has INVARIANTS enabled then those checks are always performed regardless of how the module is compiled. -- John Baldwin