From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Aug 13 19:03:05 2014 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B2B5B345 for ; Wed, 13 Aug 2014 19:03:05 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 949E120A8 for ; Wed, 13 Aug 2014 19:03:05 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s7DJ353E085586 for ; Wed, 13 Aug 2014 19:03:05 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 192642] New: update mail/mailagent to non-interactive Date: Wed, 13 Aug 2014 19:03:05 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports Tree X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ykasap@gmail.com X-Bugzilla-Status: Needs Triage X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Aug 2014 19:03:05 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192642 Bug ID: 192642 Summary: update mail/mailagent to non-interactive Product: Ports Tree Version: Latest Hardware: Any OS: Any Status: Needs Triage Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: freebsd-ports-bugs@FreeBSD.org Reporter: ykasap@gmail.com I'm using mail/mailagent daily and don't want it to be expired from the port tree, so I tried to convert it to a non-interactive, regular port. During conversion, I also found a couple of staging bugs, so these were also patched. The entire patch is a bit large, so I put it at http://eron.info/mailagent-20140814.diff The patch includes: * Remove Build-time interactive FQDN and organization name input Remove scripts/pre-configure entirely. Patch agent/magnet.sh to put an empty string into $mydomain and $hiddennet. Now bin/mailagent doesn't contain FQDN information, so a user has to specify it in ~/.mailagent. Another strategies include 1) ask during post-install and 2) retrieve dynamically, but I didn't have enough time to implement them properly (with various error checking). There is no runtime option to specify the organization name. A filename containing the organization name can be specified, so I configured to use ${PREFIX}/etc/mailagent.orgname. Add pkg-install to create empty mailagent.orgname file. Add pkg-message to notify these changes. * Fix patch files issues Revert 358579 because these Makefiles don't exist before running ./Configure. Patch Makefile.SH instead. Also the argument of "test -d" should be patched, too. Some old patch files were regenerated because they didn't match with current codes exactly. * Fix pkg-plist issues Remove some nonexistent .bak entries which prevent "make package". Add mailagent.orgname cleanup code. * Skip running post-build sanity tests mailagent has built-in sanity tests, but they don't work correctly with root privilege, so skip it entirely. I'm not sure about umask restriction, so I didn't touch that. I only tested the updated port on 10-STABLE. At least I could "make package" and install the package using pkgng on another 10.0-RELEASE host. I noticed the expiration of this port two days ago and quickly made these changes without fully understanding ports and pkg internals, so someone who knows better would you please review the patch? -- You are receiving this mail because: You are the assignee for the bug.