From owner-svn-src-all@FreeBSD.ORG Fri Feb 10 00:41:35 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6D31E1065676; Fri, 10 Feb 2012 00:41:35 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 23BDA8FC12; Fri, 10 Feb 2012 00:41:33 +0000 (UTC) Received: by wgbdq11 with SMTP id dq11so2404914wgb.31 for ; Thu, 09 Feb 2012 16:41:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:content-type :content-transfer-encoding; bh=L80gNgFxTLPKvZR5bVX5y0jTHq59M8fBxS5NeofOnzY=; b=CEX70VEndLygzl4nHk2jGQ/+qpUmt/LlPM/ZCw96TnC2Mcaf1+Q5YVSQrxpPZ6e9dA XjxiUhm+LE0Zk08KZKUyuD2d0dOQYyw2q59heAPJItfnr+CsyIj9FvvL63ZGik3CTUMk pDCf+m/AMGbqDYj0WAzEawRsiWXWm+HDQlZJU= Received: by 10.180.82.39 with SMTP id f7mr5945838wiy.19.1328834493220; Thu, 09 Feb 2012 16:41:33 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.223.103.10 with HTTP; Thu, 9 Feb 2012 16:41:03 -0800 (PST) In-Reply-To: <20120210002623.GA79894@vniz.net> References: <201202092051.q19Kp3pj028436@svn.freebsd.org> <20120210002623.GA79894@vniz.net> From: Eitan Adler Date: Thu, 9 Feb 2012 19:41:03 -0500 X-Google-Sender-Auth: 5UVzR6BmskSQDKskO9V8tdrz7So Message-ID: To: Andrey Chernov , Eitan Adler , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Gm-Message-State: ALoCoQl9wySRaU2+ycf2csDUqZETzUnc4PSVsXWMMkdxgbbV+NrXNLLPDmWA7cRMOf2RCuqJZwLv Cc: Subject: Re: svn commit: r231300 - head/usr.sbin/pkg_install/create X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Feb 2012 00:41:35 -0000 On Thu, Feb 9, 2012 at 7:26 PM, Andrey Chernov wrote: > On Thu, Feb 09, 2012 at 08:51:03PM +0000, Eitan Adler wrote: >> =C2=A0 =C2=A0 =C2=A0/* Prefix should add an @cwd to the packing list */ >> - =C2=A0 =C2=A0if (Prefix) >> - =C2=A0 =C2=A0 add_plist_top(&plist, PLIST_CWD, Prefix); >> + =C2=A0 =C2=A0if (Prefix) { >> + =C2=A0 =C2=A0 =C2=A0 =C2=A0char resolved_prefix[PATH_MAX]; >> + =C2=A0 =C2=A0 =C2=A0 =C2=A0if (realpath(Prefix, resolved_prefix) !=3D = 0) >> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 err(EXIT_FAILURE, "couldn't resolve path f= or prefix: %s", Prefix); >> + =C2=A0 =C2=A0 add_plist_top(&plist, PLIST_CWD, resolved_prefix); >> + =C2=A0 =C2=A0} > > This change cause > "pkg_create: couldn't resolve path for prefix: /usr/local: No such file o= r > directory" > because test condition should really be: Patch sent - awaiting approval. Sorry for the breakage :( --=20 Eitan Adler Source & Ports committer X11, Bugbusting teams