From owner-svn-ports-head@freebsd.org  Wed Aug  7 08:55:41 2019
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8C221C379E;
 Wed,  7 Aug 2019 08:55:41 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 463QMK37J1z4QfD;
 Wed,  7 Aug 2019 08:55:41 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 58EBF1A871; Wed,  7 Aug 2019 08:55:41 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Mark Linimon <linimon@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r508300 - head/devel/include-what-you-use
References: <201908070840.x778ejGD092822@repo.freebsd.org>
Date: Wed, 07 Aug 2019 10:55:37 +0200
In-Reply-To: <201908070840.x778ejGD092822@repo.freebsd.org> (Mark Linimon's
 message of "Wed, 7 Aug 2019 08:40:45 +0000 (UTC)")
Message-ID: <o911-9wxi-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Aug 2019 08:55:41 -0000

Mark Linimon <linimon@FreeBSD.org> writes:

> Author: linimon
> Date: Wed Aug  7 08:40:45 2019
> New Revision: 508300
> URL: https://svnweb.freebsd.org/changeset/ports/508300
>
> Log:
>   Refactor out the constant string '80' to ease future maintenance.
>
> Modified:
>   head/devel/include-what-you-use/Makefile
>
> Modified: head/devel/include-what-you-use/Makefile
> ==============================================================================
> --- head/devel/include-what-you-use/Makefile	Wed Aug  7 08:33:24 2019	(r508299)
> +++ head/devel/include-what-you-use/Makefile	Wed Aug  7 08:40:45 2019	(r508300)
> @@ -12,8 +12,9 @@ COMMENT=	Tool for use with clang to analyze #includes 
>  LICENSE=	NCSA
>  LICENSE_FILE=	${WRKSRC}/LICENSE.TXT
>  
> -BUILD_DEPENDS=	clang80:devel/llvm80
> -RUN_DEPENDS=	clang80:devel/llvm80
> +LLVM_VER=	80
> +BUILD_DEPENDS=	clang${LLVM_VER}:devel/llvm${LLVM_VER}
> +RUN_DEPENDS=	clang${LLVM_VER}:devel/llvm${LLVM_VER}
>  
>  USES=		cmake compiler:c++11-lang ncurses python:run shebangfix
>  USE_GITHUB=	yes
> @@ -23,7 +24,7 @@ SHEBANG_FILES=	fix_includes.py \
>  
>  GH_TAGNAME=	clang_8.0

Either LLVM_VER or GH_TAGNAME should be eliminated to avoid redundancy.