From owner-freebsd-current@FreeBSD.ORG  Fri May  7 18:03:37 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@www.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7914F16A4CE
	for <freebsd-current@www.freebsd.org>;
	Fri,  7 May 2004 18:03:37 -0700 (PDT)
Received: from smtp01.syd.iprimus.net.au (smtp01.syd.iprimus.net.au
	[210.50.30.52])	by mx1.FreeBSD.org (Postfix) with ESMTP id 7181E43D60
	for <freebsd-current@www.freebsd.org>;
	Fri,  7 May 2004 18:03:36 -0700 (PDT)
	(envelope-from tim@robbins.dropbear.id.au)
Received: from robbins.dropbear.id.au (210.50.216.161) by
	smtp01.syd.iprimus.net.au (7.0.024)
	id 409956B4000FB4AB; Sat, 8 May 2004 11:02:53 +1000
Received: by robbins.dropbear.id.au (Postfix, from userid 1000)
	id 30A6941C6; Sat,  8 May 2004 11:02:28 +1000 (EST)
Date: Sat, 8 May 2004 11:02:28 +1000
From: Tim Robbins <tjr@freebsd.org>
To: Bruce M Simpson <bms@spc.org>
Message-ID: <20040508010228.GA18935@cat.robbins.dropbear.id.au>
References: <20040507092235.GA61837@stack.nl>
	<20040507100119.GA15782@cat.robbins.dropbear.id.au>
	<20040507235556.GB37035@empiric.dek.spc.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040507235556.GB37035@empiric.dek.spc.org>
User-Agent: Mutt/1.4.1i
cc: Marc Olzheim <marcolz@stack.nl>
cc: Poul-Henning Kamp <phk@phk.freebsd.dk>
cc: freebsd-current@www.freebsd.org
Subject: Re: Unified getcwd() implementation
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 08 May 2004 01:03:37 -0000

On Sat, May 08, 2004 at 12:55:56AM +0100, Bruce M Simpson wrote:

> On Fri, May 07, 2004 at 08:01:19PM +1000, Tim Robbins wrote:
> > Why is this necessary? Emulation of the Linux getcwd() syscall belongs
> > in the Linux emulator. There is also some fairly blatantly plagiarised code
> > in this patch.
> 
> I rolled the patch before I was a committer in response to an item on
> PHK's JKH tasklist.
> 
> The getcwd() implementation in the Linux module is not inherently Linux
> specific; but it does implement the name-finding without using the name
> cache, by scanning directories. The patch merges the name cache and
> non-name-cache based implementations of getcwd() to address the PRs which
> Marc cited in his earlier message.

It's not inherently Linux-specific, but it exists solely for the benefit
of Linux emulation. I don't see why they need to be merged at the
expense of complicating the native system calls -- we have way
too many tentacles of the Linux emulator reaching in there already.

> You seem to be concerned about plagiarism. Could you clarify or explain
> your concerns?

getcwd_scandir() has clearly been copied from linux_getcwd.c. The work
needs to be attributed to the author, Bill Sommerfeld, and the NetBSD
license needs to be honoured.


Tim