Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 24 Feb 2012 12:27:36 -0500 (EST)
From:      Michael Scheidell <scheidell@FreeBSD.org>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/165454: small patch www/nginx. re-order extra_commands
Message-ID:  <20120224172736.50B431D403@scanner.secnap.net>
Resent-Message-ID: <201202241730.q1OHUELx033955@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         165454
>Category:       ports
>Synopsis:       small patch www/nginx. re-order extra_commands
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Feb 24 17:30:13 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Michael Scheidell
>Release:        FreeBSD 7.4-RELEASE-p3 i386
>Organization:
SECNAP Network Security
>Environment:

>Description:

Can I beg for a small change to order of extra_commands in ../nginx rc file?
The way it is, anyone who want to add to this, with a /etc/rc.conf.d/nginx file won't get their 'special' hacks included.
By putting extra_commands ahead of the load_rc_config $name, it gives more of a standard ability for customizations.

this should be 100% upward compatible, don't need a portrevision bump, so no rebuilds needed, just makes it more comparible.
thanks.

- Update order of extra_commands in rc file to facilitate custom scripts
- no PORTREVISION bump

>How-To-Repeat:

add an extra command to /etc/rc.conf.d and execute service nginx {new command}

>Fix:

this small patch. thanks.

--- nginx.sh.patch begins here ---
Index: files/nginx.sh.in
===================================================================
RCS file: /home/pcvs/ports/www/nginx/files/nginx.sh.in,v
retrieving revision 1.10
diff -u -r1.10 nginx.sh.in
--- files/nginx.sh.in	14 Jan 2012 08:57:15 -0000	1.10
+++ files/nginx.sh.in	24 Feb 2012 17:22:07 -0000
@@ -35,6 +35,7 @@
 _pidprefix="/var/run/nginx"
 pidfile="${_pidprefix}.pid"
 required_files=%%PREFIX%%/etc/nginx/nginx.conf
+extra_commands="reload configtest upgrade gracefulstop"
 
 [ -z "$nginx_enable" ]		&& nginx_enable="NO"
 [ -z "$nginxlimits_enable" ]	&& nginxlimits_enable="NO"
@@ -118,5 +119,4 @@
 	fi
 }
 
-extra_commands="reload configtest upgrade gracefulstop"
 run_rc_command "$1"
--- nginx.sh.patch ends here ---

______________________________________________________________________
This email has been scanned and certified safe by SpammerTrap(r). 
For Information please see http://www.spammertrap.com/
______________________________________________________________________  
  
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120224172736.50B431D403>