From owner-cvs-all@FreeBSD.ORG Mon Jan 2 08:51:23 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5D22A16A41F; Mon, 2 Jan 2006 08:51:23 +0000 (GMT) (envelope-from brian@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9E50C43D68; Mon, 2 Jan 2006 08:51:22 +0000 (GMT) (envelope-from brian@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k028pMfc051064; Mon, 2 Jan 2006 08:51:22 GMT (envelope-from brian@repoman.freebsd.org) Received: (from brian@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k028pMLR051063; Mon, 2 Jan 2006 08:51:22 GMT (envelope-from brian) Message-Id: <200601020851.k028pMLR051063@repoman.freebsd.org> From: Brian Somers Date: Mon, 2 Jan 2006 08:51:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/su su.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jan 2006 08:51:23 -0000 brian 2006-01-02 08:51:21 UTC FreeBSD src repository Modified files: usr.bin/su su.c Log: Remove broken code that mucks about with tcsetpgrp() -- even if su isn't the foreground process. Hopefully this won't break PAM, but I couldn't find any useful information about ache's theory that it will. Specifically, this change fixes the following: # sh # echo $$ # su - root -c id & # echo $$ The PID output changes as su seems to be kill -STOP'ing itself and catching the parent shell in the process. This is especially bad if you add a ``su - user -c command &'' to an rc script! Sponsored by: Sophos/Activestate Not objected to by: des Revision Changes Path 1.77 +0 -7 src/usr.bin/su/su.c