From owner-cvs-doc@FreeBSD.ORG  Wed Jun  9 10:53:02 2010
Return-Path: <owner-cvs-doc@FreeBSD.ORG>
Delivered-To: cvs-doc@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C2BBD1065677;
	Wed,  9 Jun 2010 10:53:02 +0000 (UTC)
	(envelope-from uqs@spoerlein.net)
Received: from acme.spoerlein.net (acme.spoerlein.net [IPv6:2001:470:9a47::1])
	by mx1.freebsd.org (Postfix) with ESMTP id 3A4F58FC19;
	Wed,  9 Jun 2010 10:53:02 +0000 (UTC)
Received: from acme.spoerlein.net (localhost.spoerlein.net [IPv6:::1])
	by acme.spoerlein.net (8.14.4/8.14.4) with ESMTP id o59Ar1BS023088
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Wed, 9 Jun 2010 12:53:01 +0200 (CEST)
	(envelope-from uqs@spoerlein.net)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=spoerlein.net;
	s=dkim200908; t=1276080781;
	bh=zahEEBa5a6BECTwp7bdJ66yN8Nx7wjxDdhNFGFSdGhs=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	Content-Type:In-Reply-To;
	b=IzuhbXDyF0xXb/VsYYXTXp3DksNlnqK6SCblCCvNuqPscqBz/GA2OnHvPony9Urmh
	h084x8FgO8rV5UKnNFOYXDyg/RqmdbgfKR5UG87UNgqBDl/eRTCjZ+z7D9SprW0idE
	rUtDniXptg42qHfi9j9IQboA/MYggzZtwYYLNb2g=
Received: (from uqs@localhost)
	by acme.spoerlein.net (8.14.4/8.14.4/Submit) id o59Ar1fa023087;
	Wed, 9 Jun 2010 12:53:01 +0200 (CEST)
	(envelope-from uqs@spoerlein.net)
Date: Wed, 9 Jun 2010 12:53:01 +0200
From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= <uqs@spoerlein.net>
To: Doug Barton <dougb@freebsd.org>
Message-ID: <20100609105300.GN39829@acme.spoerlein.net>
References: <201006041730.o54HUlnc016635@repoman.freebsd.org>
	<4C093F30.6050103@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4C093F30.6050103@FreeBSD.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: Matthew D Fleming <mdf@freebsd.org>, doc-committers@freebsd.org,
	cvs-doc@freebsd.org, cvs-all@freebsd.org, zml@freebsd.org
Subject: Re: cvs commit: doc/en_US.ISO8859-1/share/sgml authors.ent
X-BeenThere: cvs-doc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the doc and www trees <cvs-doc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-doc>,
	<mailto:cvs-doc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-doc>
List-Post: <mailto:cvs-doc@freebsd.org>
List-Help: <mailto:cvs-doc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-doc>,
	<mailto:cvs-doc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Jun 2010 10:53:02 -0000

On Fri, 04.06.2010 at 11:00:16 -0700, Doug Barton wrote:
> On 06/04/10 10:30, Matthew D Fleming wrote:
> > mdf         2010-06-04 17:30:47 UTC
> >
> >    FreeBSD doc repository (src committer)
> >
> >    Modified files:
> >      en_US.ISO8859-1/share/sgml authors.ent
> >    Log:
> >    Add myself to the list of committers.
> >
> >    Revision  Changes    Path
> >    1.509     +2 -0      doc/en_US.ISO8859-1/share/sgml/authors.ent
> >
> > http://www.FreeBSD.org/cgi/cvsweb.cgi/doc/en_US.ISO8859-1/share/sgml/authors.ent.diff?&r1=1.508&r2=1.509&f=h
> 
> Matthew,
> 
> Couple of things ... first, welcome to the fun! Second, (and your mentor 
> really should be filling you in on this stuff) it's customary for 
> related commits in the same tree to go in together. So rather than 
> committing these doc updates one at a time it would have been better to 
> get all the related stuff in one go. Also, until you're released from 
> mentorship ALL of your commits should indicate that they were approved 
> by your mentor (which implies of course that zml reviews them first).

The handbook is somewhat misleading in this regard, as it warns you that
the www build may break if stuff happens in the wrong order. People may
therefore opt to err on the side of caution by putting stuff in
sequentially.

Uli