From owner-svn-src-head@freebsd.org Fri Jan 22 16:06:53 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 15B6DA8C7B8; Fri, 22 Jan 2016 16:06:53 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mx1.sbone.de (bird.sbone.de [46.4.1.90]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id CC3A21C69; Fri, 22 Jan 2016 16:06:52 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 7D1B425D38A4; Fri, 22 Jan 2016 16:06:42 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 17ED6C76FF9; Fri, 22 Jan 2016 16:06:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id E0P13FMhxYhy; Fri, 22 Jan 2016 16:06:39 +0000 (UTC) Received: from [IPv6:fde9:577b:c1a9:4410:6013:8c56:5f43:887c] (unknown [IPv6:fde9:577b:c1a9:4410:6013:8c56:5f43:887c]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id DDF4FC76FF5; Fri, 22 Jan 2016 16:06:38 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: svn commit: r294535 - in head/sys/netinet: . cc tcp_stacks From: "Bjoern A. Zeeb" In-Reply-To: <058BD5D5-C1AC-45DA-B6BE-2EDC4D64F67F@neville-neil.com> Date: Fri, 22 Jan 2016 16:06:19 +0000 Cc: Lawrence Stewart , Gleb Smirnoff , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201601212234.u0LMYpKT009948@repo.freebsd.org> <56A1D6B2.1010406@freebsd.org> <058BD5D5-C1AC-45DA-B6BE-2EDC4D64F67F@neville-neil.com> To: George Neville-Neil X-Mailer: Apple Mail (2.2104) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jan 2016 16:06:53 -0000 > On 22 Jan 2016, at 15:21 , George Neville-Neil = wrote: >=20 >=20 >=20 > On 22 Jan 2016, at 2:13, Lawrence Stewart wrote: >=20 >> Hi Gleb, >>=20 >> On 01/22/16 09:34, Gleb Smirnoff wrote: >>> Author: glebius >>> Date: Thu Jan 21 22:34:51 2016 >>> New Revision: 294535 >>> URL: https://svnweb.freebsd.org/changeset/base/294535 >>>=20 >>> Log: >>> - Rename cc.h to more meaningful tcp_cc.h. >>=20 >> As a bit of historical context, the naming was intentionally protocol >> agnostic because it was originally hoped that the CC framework could = be >> shared between multiple CC aware transports, and the design went to = some >> lengths to accommodate that possibility (e.g. the ccv_container union = in >> struct cc_var). SCTP was the obvious potential in tree consumer at = the >> time, and other protocols like DCCP were considered as well. >>=20 >> This hasn't come about to date, but I'm not sure what value is = obtained >> from your rename change unless we decide to completely give up on = shared >> CC and if we do that, this change doesn't go far enough and we can >> further simplify the framework to make it entirely TCP specific e.g. = we >> should probably do away with struct cc_var. >>=20 >> I'd argue in favour of reverting the rename and if you're gung ho = about >> making the framework TCP specific, we can start a public discussion >> about what that should look like. >>=20 >=20 > I actually was wondering about this as well. I think it ought to be = reverted to agnostic. I probably share that view but I also agree that cc.h is not a good = name. So before we entirely revert this, can when maybe come up with a name = that is better than cc.h or tcp_cc.h and only make this one more change = forward rather than going back to the previous status quo? /bz=