From owner-cvs-all@FreeBSD.ORG Fri Feb 13 15:39:56 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 19A7216A4CE; Fri, 13 Feb 2004 15:39:56 -0800 (PST) Received: from rwcrmhc13.comcast.net (rwcrmhc13.comcast.net [204.127.198.39]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0DF6743D1F; Fri, 13 Feb 2004 15:39:56 -0800 (PST) (envelope-from julian@elischer.org) Received: from interjet.elischer.org ([24.7.73.28]) by comcast.net (rwcrmhc13) with ESMTP id <2004021323395501500h1i4pe>; Fri, 13 Feb 2004 23:39:55 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id PAA28476; Fri, 13 Feb 2004 15:39:54 -0800 (PST) Date: Fri, 13 Feb 2004 15:39:53 -0800 (PST) From: Julian Elischer To: Scott Long In-Reply-To: <20040213152836.U25703@pooker.samsco.home> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Julian Elischer cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/bfe if_bfe.c if_bfereg.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Feb 2004 23:39:56 -0000 Oh I'm standing by it.. This version is working for me so far but I have heard rumours that the -current driver has an occasional 'hang'. There is another rumour that this driver has inherritted the problem, but I have never seen it.. The driver is not built by default and the module will not build unless you specifically edit out the line that tells you there may be problems.. so I don't see how this affects anyone, but it DOES give people a way of trying it out.. I will be supporting it because we (Vicor) plan on using this driver in production on 4.x. So I need to have it reliable. My main test machine is out of commision for a couple of days but I found a laptop (Dell 5150) with the same chip and that allowed me to confirm that this now works.. It's been in use on that machine without problems for a short while and I'll be backing it up with the debug machine (with full gdb/ddb support) as soon as it comes back from being repaired. When I have it back I will be looking at possibly merging in some fixes from Dragonfly (via -current). > On Fri, 13 Feb 2004, Julian Elischer wrote: > > julian 2004/02/13 13:36:34 PST > > > > FreeBSD src repository > > > > Modified files: (Branch: RELENG_4) > > sys/dev/bfe if_bfe.c if_bfereg.h > > Log: > > Upgrade to the version of the MFC by Edwin Groothuis. > > This seems to work but I have heard of hangs... > > > > Revision Changes Path > > 1.4.4.3 +101 -91 src/sys/dev/bfe/if_bfe.c > > 1.1.4.3 +12 -0 src/sys/dev/bfe/if_bfereg.h > > > > > > Julian, > > Are you willing to stand by this commit? Your comment implies that you > don't know if it works or not. If so, then RELENG_4 is certainly not the > place for this. Mr. Groothuis might have done a fine job with this, but > unless you as a committer and senior member of this project are willing > to actually review, test, and validate it, then it needs to be backed out > and revisited at a later date. > > Scott >