From owner-dev-commits-src-all@freebsd.org Thu Jan 7 23:41:53 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 87B194E089F; Thu, 7 Jan 2021 23:41:53 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DBjSK3SWmz4b4c; Thu, 7 Jan 2021 23:41:53 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from [192.168.1.10] (c-98-207-126-143.hsd1.ca.comcast.net [98.207.126.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id B7BE9293F1; Thu, 7 Jan 2021 23:41:52 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/16.44.20121301 Date: Thu, 07 Jan 2021 15:41:48 -0800 Subject: Re: 92cf602e3809 - main - Copy strcasestr.c from libc to libkern. From: Ravi Pokala To: Vladimir Kondratyev , Jessica Clarke , Vladimir Kondratyev CC: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Message-ID: <3EA011C9-2EEC-4693-B36D-69E74DF8473C@panasas.com> Thread-Topic: 92cf602e3809 - main - Copy strcasestr.c from libc to libkern. References: <202101072320.107NKpMS063374@gitrepo.freebsd.org> <7a7fa0fb-51c2-1b14-6d37-2c400f69d7dd@kondratyev.su> In-Reply-To: <7a7fa0fb-51c2-1b14-6d37-2c400f69d7dd@kondratyev.su> Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: 7bit X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jan 2021 23:41:53 -0000 -----Original Message----- From: on behalf of Vladimir Kondratyev Date: 2021-01-07, Thursday at 15:33 To: Jessica Clarke , Vladimir Kondratyev Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 92cf602e3809 - main - Copy strcasestr.c from libc to libkern. On 08.01.2021 02:27, Jessica Clarke wrote: > On 7 Jan 2021, at 23:20, Vladimir Kondratyev wrote: >> +#include >> +#include >> +#include "xlocale_private.h" >> + >> +/* >> + * Find the first occurrence of find in s, ignore case. >> + */ >> +char * >> +strcasestr_l(const char *s, const char *find, locale_t locale) > > Locales in the kernel? This feels wrong. > > Jess > strcasestr.c was copied from userland unmodified just to allow "git log --follow" to work. Next commit removed locale support from this file and connected it to build. Unfortunately, about two-dozen commit messages from you arrived at the same time, and some were out of order; without incrementing change numbers in the subject line, figuring out the actual ordering is non-trivial. :-p -Ravi (rpokala@)