From owner-cvs-all Fri Jan 31 12:17:28 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DA88737B407 for ; Fri, 31 Jan 2003 12:17:26 -0800 (PST) Received: from mail.speakeasy.net (mail11.speakeasy.net [216.254.0.211]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0622743F79 for ; Fri, 31 Jan 2003 12:17:25 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 28016 invoked from network); 31 Jan 2003 20:17:31 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail11.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 31 Jan 2003 20:17:31 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id h0VKHLUT072805; Fri, 31 Jan 2003 15:17:21 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: Date: Fri, 31 Jan 2003 15:17:27 -0500 (EST) From: John Baldwin To: Julian Elischer Subject: RE: cvs commit: src/sys/kern subr_trap.c Cc: "Tim J. Robbins" , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 31-Jan-2003 Julian Elischer wrote: > > > On Fri, 31 Jan 2003, John Baldwin wrote: > >> >> On 31-Jan-2003 Julian Elischer wrote: >> > >> > do you know of any other problems? >> >> thread_statclock() has a similar problem as others have noticed: > > what others? > > why doesn't anyone tell ME these things? > is there some discussion going on in a places I don't see? like IRC? ----- revision 1.77 date: 2003/01/26 11:41:34; author: davidxu; state: Exp; lines: +646 -513 Move UPCALL related data structure out of kse, introduce a new data structure called kse_upcall to manage UPCALL. All KSE binding and loaning code are gone. ... Reviewed by: julian ----- Read that last line. What does that mean to you? To me it means that you have looked at the actual diff and approved it. You didn't see any bugs in it, etc. Now, either you didn't look very hard, or that last line is a lie. Either way, I want this commit backed out until such time as it has a 'Reviewed by' line that means something. It's not enough to just keep fixing the bugs that others find when they crop up. Saying that you reviewed something means that you should be taking responsibility to test things out and really look at them before they are committed. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message