From owner-cvs-src@FreeBSD.ORG Tue Jul 3 18:32:10 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7EBDB16A468; Tue, 3 Jul 2007 18:32:10 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id 2A0E113C4BC; Tue, 3 Jul 2007 18:32:09 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l63IW6mQ006881; Tue, 3 Jul 2007 14:32:07 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Konstantin Belousov Date: Tue, 3 Jul 2007 12:14:33 -0400 User-Agent: KMail/1.9.6 References: <200707031558.l63FwmJx077238@repoman.freebsd.org> In-Reply-To: <200707031558.l63FwmJx077238@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200707031214.34272.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 03 Jul 2007 14:32:07 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/3586/Tue Jul 3 12:11:56 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern sysv_sem.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2007 18:32:10 -0000 On Tuesday 03 July 2007 11:58:48 am Konstantin Belousov wrote: > kib 2007-07-03 15:58:48 UTC > > FreeBSD src repository > > Modified files: > sys/kern sysv_sem.c > Log: > Relock the sema_mtxp unconditionally after copyin() for SETALL case in > kern_semctl. Otherwise, later mtx_unlock() can operate on unlocked mutex. > > Submitted by: rdivacky > MFC after: 3 days > Approved by: re (kensmith) Good catch. Another thing you could fix is to make all the 'goto done2' inside the switch cases just use 'break' instead. -- John Baldwin