From owner-cvs-games Mon May 12 23:43:18 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id XAA04403 for cvs-games-outgoing; Mon, 12 May 1997 23:43:18 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id XAA04386; Mon, 12 May 1997 23:43:05 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.5/8.6.9) id QAA14766; Tue, 13 May 1997 16:21:59 +1000 Date: Tue, 13 May 1997 16:21:59 +1000 From: Bruce Evans Message-Id: <199705130621.QAA14766@godzilla.zeta.org.au> To: asami@FreeBSD.ORG, cvs-all@FreeBSD.ORG, CVS-committers@FreeBSD.ORG, cvs-games@FreeBSD.ORG Subject: Re: cvs commit: src/games/adventure Makefile Sender: owner-cvs-games@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > Modified: games/adventure Makefile > Log: > Add ${CFLAGS} and ${LDFLAGS} to the setup command line. Please improve low quality makefiles instead of adding more cruft to them. Removing the explicit rule gives better results (the implicit null suffix rule ".c" gets used). The dependencies for `setup' are still broken. Tools like `setup' are most easily handled by putting them in a separate directory, although this causes different problems with dependencies. There should be more general support for tools. See bin/sh for a more interesting example. The dependencies for sh are complicated enough as it is (it's hard to make them correct enough for -j3 to work) and putting the tools in separate directories wouldn't help (see tn3270 for how badly this works). Bruce