From nobody Thu Jul 2 12:57:06 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4grcNM0cp2z5q2q9 for ; Thu, 02 Jul 2026 12:57:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4grcNL6xTMz3mch for ; Thu, 02 Jul 2026 12:57:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782997027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1BfrvJw3N8hBRIZV8s5Ml4dyslNX9bf7mZDI+p2DnXE=; b=k+s9/Q4H566fSGCd66f3Bw2/k3YnjmtD59tVQoDmLVHKsaiS2abKiG3PJr7KPGZIVfewbf p+7AnQa5HMQpN0cuyvSvNRo4sXKm9ZQGEoYY2kaQN1KEoiG5ig7/TFoDjhlE4y6BHI5tX8 wHOrZAN1aEf8qHtgNQtgud1FDvKVGs4O8GRKMBf9TlMQvRVNGUDYDMVV7eXw2yDkJio2FB XFWgbeM5TUz/PqfYwLY8CnMSHrKgfWY4cBmzW1mFoIUavvoxB5O1Lpbj9ClpsXL9N2nquz eYqnwSI0a01QBafUpEpnemp6Dor1yF3GHq+zf6RxUtFdn+OhZNEKcotiGIFv2Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782997027; a=rsa-sha256; cv=none; b=uKqcwuuRUHmWLeHtoT0vRypkR7/7sTWLBEdvi7It7yot8jZoqtXr9uIFQhNIycboB9lXZH LbnyCm7acKmxEDFktbSxk5IaqWgV5trxu4EtOAHtjYznTr1MkSF+zyZRH90aRRtZnVgvyW OBdvzi8FGpfLeuweDoNNlPOZbe6tNlHjRUfoYNNVal3XuuNm07l47jURyGWVZpvHXF4bi4 b9ONbtDdF69O1s7znTC3pkPgCA1Daovwtq738H3eVpSIWKuUff5KwhoTyQ6TRrgH+7VLvs PhT68O8OscRUsOP4KTAY5TeJkLwMxVlhQ94TVK0RE+R867znu4Q+pd7+ZHn6kg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782997027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1BfrvJw3N8hBRIZV8s5Ml4dyslNX9bf7mZDI+p2DnXE=; b=FxTmecK79VS3LLZD9NqLZkBcC2xRSPIUstewuO6uQ5TtiZvQRUrgWO9HNtMsEsPbejVcDE PR0UK97Rx48mG10EzaorjrQDy8cphJvP6TZGuPRTIyvs8MRDNEz1zL2IEl2b4oUKmzfU8T VOt0CMG1DYPgrc8DcfpNjWsoy0+qThSADL3IMrsmXBn/DISiti7RGVA1e8DDwmjo8J43SM gywK+lKBpak8SaK1KSJY5vcvuAcVwvqFirxKlwX2VjVMC6Zqf9TORIWTPEos39xexsINAX wYwRBLjB0Fdhip8mwxf+huidJ14thvWCJZa0TUgfAX9jspNIYJkcyEm7+NcwIg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4grcNL5f8Cz12Fg for ; Thu, 02 Jul 2026 12:57:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 361d3 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 02 Jul 2026 12:57:06 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Christos Margiolis Subject: git: 8163944f2739 - stable/15 - sound: Retire unused SD_F_EQ_PC List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 8163944f2739733a0bb9265416a3687ec33691ff Auto-Submitted: auto-generated Date: Thu, 02 Jul 2026 12:57:06 +0000 Message-Id: <6a466022.361d3.370846c9@gitrepo.freebsd.org> The branch stable/15 has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=8163944f2739733a0bb9265416a3687ec33691ff commit 8163944f2739733a0bb9265416a3687ec33691ff Author: Christos Margiolis AuthorDate: 2026-06-24 13:47:05 +0000 Commit: Christos Margiolis CommitDate: 2026-07-02 12:56:53 +0000 sound: Retire unused SD_F_EQ_PC This flag is neither set anywhere, nor is there a way to set it from userland, so it is effectively useless, and currently the effect is that EQ can only be enabled for primary playback channels. Retire the flag and keep this behavior, and think later whether we want to allow virtual channels to get their own EQ feeder as well. Sponsored by: The FreeBSD Foundation MFC after: 1 week (cherry picked from commit ede0236d3b34a89bae7795f0f45696d4d94ce138) --- sys/dev/sound/pcm/feeder_chain.c | 6 ++---- sys/dev/sound/pcm/sound.h | 4 ++-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/sys/dev/sound/pcm/feeder_chain.c b/sys/dev/sound/pcm/feeder_chain.c index 1dbdf2fcc0e4..dc0788ffb53c 100644 --- a/sys/dev/sound/pcm/feeder_chain.c +++ b/sys/dev/sound/pcm/feeder_chain.c @@ -725,10 +725,8 @@ feeder_chain(struct pcm_channel *c) /* Soft EQ only applicable for PLAY. */ if (cdesc.dummy == 0 && - c->direction == PCMDIR_PLAY && (d->flags & SD_F_EQ_ENABLED) && - (((d->flags & SD_F_EQ_PC) && - !(c->flags & CHN_F_HAS_VCHAN)) || - (!(d->flags & SD_F_EQ_PC) && !(c->flags & CHN_F_VIRTUAL)))) + c->direction == PCMDIR_PLAY && + (d->flags & SD_F_EQ_ENABLED) && !(c->flags & CHN_F_VIRTUAL)) cdesc.use_eq = 1; if (FEEDFORMAT_NE_REQUIRED(&cdesc)) { diff --git a/sys/dev/sound/pcm/sound.h b/sys/dev/sound/pcm/sound.h index becd787a456a..fea27921e7db 100644 --- a/sys/dev/sound/pcm/sound.h +++ b/sys/dev/sound/pcm/sound.h @@ -105,7 +105,7 @@ struct snd_mixer; /* unused 0x00000100 */ #define SD_F_EQ_ENABLED 0x00000200 /* EQ enabled */ /* unused 0x00000400 */ -#define SD_F_EQ_PC 0x00000800 /* EQ per-channel */ +/* unused 0x00000800 */ #define SD_F_PVCHANS 0x00001000 /* Playback vchans enabled */ #define SD_F_RVCHANS 0x00002000 /* Recording vchans enabled */ @@ -121,7 +121,7 @@ struct snd_mixer; /* "\011 */ \ "\012EQ_ENABLED" \ /* "\013 */ \ - "\014EQ_PC" \ + /* "\014 */ \ "\015PVCHANS" \ "\016RVCHANS"