From owner-svn-src-all@FreeBSD.ORG Thu Apr 2 18:23:24 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BEF96198; Thu, 2 Apr 2015 18:23:24 +0000 (UTC) Received: from mail.turbocat.net (mail.turbocat.net [IPv6:2a01:4f8:d16:4514::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 74A8EDD0; Thu, 2 Apr 2015 18:23:24 +0000 (UTC) Received: from laptop015.home.selasky.org (cm-176.74.213.204.customer.telag.net [176.74.213.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 610851FE022; Thu, 2 Apr 2015 20:23:22 +0200 (CEST) Message-ID: <551D8945.8050906@selasky.org> Date: Thu, 02 Apr 2015 20:24:05 +0200 From: Hans Petter Selasky User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Robert Watson , Mateusz Guzik Subject: Re: svn commit: r280971 - in head: contrib/ipfilter/tools share/man/man4 sys/contrib/ipfilter/netinet sys/netinet sys/netipsec sys/netpfil/pf References: <201504012226.t31MQedN044443@svn.freebsd.org> <1427929676.82583.103.camel@freebsd.org> <20150402123522.GC64665@FreeBSD.org> <20150402133751.GA549@dft-labs.eu> <20150402134217.GG64665@FreeBSD.org> <20150402135157.GB549@dft-labs.eu> <1427983109.82583.115.camel@freebsd.org> <20150402142318.GC549@dft-labs.eu> <20150402143420.GI64665@FreeBSD.org> <20150402153805.GD549@dft-labs.eu> <551D8143.4060509@selasky.org> In-Reply-To: <551D8143.4060509@selasky.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Gleb Smirnoff , src-committers@freebsd.org, Ian Lepore X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Apr 2015 18:23:24 -0000 On 04/02/15 19:49, Hans Petter Selasky wrote: > On 04/02/15 18:00, Robert Watson wrote: >> On Thu, 2 Apr 2015, Mateusz Guzik wrote: >> >>>> If you carefully read the thread I referred to, you would notice that >>>> on many arches, save amd64 and i386, all systems stats are prone to >>>> mangling the stats due to migration within PCPU_INC. Look here: >>>> >>>> grep '^#define PCPU_ADD' sys/*/include/pcpu.h >>>> >>>> Do we have reports on not precise enough statistics, yet? >>> >>> How many non-x86 installations with multiple cpus and high traffic are >>> out there? >> >> Not sure if this was a rhetorical question or not, but: quite a few. We >> have support for several highly threaded 64-bit MIPS systems including >> those from Cavium and Broadcom (was NetLogic Micro was RMI). Several >> reference systems are in the netperf cluster including 16- and 32-thread >> systems normally deployed in high-performance network products. It's >> possible that ARMv8 systems will gradually displayce 64-bit MIPS systems >> in this arena in the future, but hard to say. Either way, it's not x86. >> :-) >> > > Hi, > > I've sketched up my proposal here, please have a look. > > https://reviews.freebsd.org/D2211 > > --HPS > Hi, In my sketchup I assume that packets for the same destination will not be re-ordered. I see that the current ip_reass() code does not care about TCP or UDP port numbers at all. Maybe we should add code to check that the packet belongs to the same ports too? Does somebody here know what happens in these two cases: If we are transmitting using TSO, will the network adapter increment the IP ID field somehow? What happens if an outgoing IP packet resulting from a TSO packet get fragmented by a router? In ip_fragment() when we create fragments we should increment the ip_id value for each fragment? --HPS