From owner-svn-src-all@freebsd.org Wed Feb 8 13:01:50 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 72D0BCD6F92; Wed, 8 Feb 2017 13:01:50 +0000 (UTC) (envelope-from sgalabov@gmail.com) Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 06C688BE; Wed, 8 Feb 2017 13:01:50 +0000 (UTC) (envelope-from sgalabov@gmail.com) Received: by mail-wm0-x243.google.com with SMTP id u63so33120748wmu.2; Wed, 08 Feb 2017 05:01:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:mime-version:subject:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=97uQQPCZN3ZfLJ1CopBMoOgXBpIYlWWB0hgsXU8SmvA=; b=uAATg9mJWWvXdBb2wvzB2tN+C5i/+LcdKeUQHxjrw9xavaBe8KV/1CrHRDcVrKAiHN s6GN10dZmlvYq1J0a+uV0Th4g1Mef71nVw1cdP7BpZEwd9kErOhxY/HxAkw0DItE0Vm4 mWzPBNWyFh8NZXxTVU0YTozn8ulW8apFHdPZKK0o/pKIpGmsKZ1hp0WRG9zwvgNHnW1n 51TDHo11PfKEuRn2Kbtkk6Yce9CwTrnMsw+vTrd6SsAUdzITUdDsQSn+UfB/gvRn8Wrn adtQ1TbVasZTZru2YxhI0oRJX/Hui6NsJh4cqWbtv43/FMF0M/+kVEjFyi6Heclxq5Zb jHlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=97uQQPCZN3ZfLJ1CopBMoOgXBpIYlWWB0hgsXU8SmvA=; b=dJFo1JDgf0Aks94x8LSFIMTF2zJLfCTvknzzemS+xWGScdlke1CqlNQ4qtGxI4at4Z lw/0nU/HDYz1fz7IlCVfmspjMMzvlluKe0LBF3TJiXgGOYCOQV9y7auLSD1ISDwEAi+u eiWsPOinzQ3h/BvCuSBORedO8gLEIx5kh/Bly0TnNtaYi5zkTVazWqpE0cZnqtq3NSjy joVQigP5+e3r4Q2KSq6TMs1N3mneSpwl2/+d+mCPOicaZ+nXImNLEW0AkUMuIHecXri4 ZUL4LhVBS2FIbuqg3JgLYvUYZPkYAdT0GNFH/RkkWlsCl8mEk6M913MXECFBGW7IOIVg 3Mbw== X-Gm-Message-State: AMke39mFCp4N2xRSbWKyQv9RyR58szos396b/UMN8qrKXW2cweL2nsRRit8s82weatVYOg== X-Received: by 10.28.45.197 with SMTP id t188mr19203822wmt.15.1486558908586; Wed, 08 Feb 2017 05:01:48 -0800 (PST) Received: from [192.168.252.71] ([193.178.153.36]) by smtp.gmail.com with ESMTPSA id a13sm3264760wma.13.2017.02.08.05.01.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Feb 2017 05:01:47 -0800 (PST) From: Stanislav Galabov X-Google-Original-From: Stanislav Galabov Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.0 \(3226\)) Subject: Re: svn commit: r313343 - head/sys/arm/arm In-Reply-To: Date: Wed, 8 Feb 2017 15:01:46 +0200 Cc: Stanislav Galabov , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <27DC1078-9C59-4B6C-A9CF-9E6D246F7366@FreeBSD.org> References: <201702061458.v16EwOjU015633@repo.freebsd.org> To: Ronald Klop X-Mailer: Apple Mail (2.3226) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Feb 2017 13:01:50 -0000 Hi, I hadn=E2=80=99t looked at 11-CURRENT to be honest, but looking at it - = yes, it seems is applicable there too. Unfortunately I am not certain I=E2=80=99ll have time to MFC this, so if = anyone wants to/has the time - please be my guest. Best wishes, Stanislav > On Feb 8, 2017, at 14:58, Ronald Klop wrote: >=20 > Hello, >=20 > Is this applicable to 11-CURRENT also? >=20 > That version (sys/arm/arm/identcpu.c) has: > void > identify_arm_cpu(void) > { > u_int cpuid, reg, size, sets, ways; > u_int8_t type, linesize, ctrl; > int i; >=20 > Regards, > Ronald. >=20 >=20 > On Mon, 06 Feb 2017 15:58:24 +0100, Stanislav Galabov = wrote: >=20 >> Author: sgalabov >> Date: Mon Feb 6 14:58:24 2017 >> New Revision: 313343 >> URL: https://svnweb.freebsd.org/changeset/base/313343 >>=20 >> Log: >> sys/arm/arm/identcpu-v4.c: fix identify_arm_cpu() >> identify_arm_cpu() in sys/arm/arm/identcpu-v4.c incorrectly uses a >> u_int8_t variable to store the result of cpu_get_control(). >> It should really use a u_int variable, the same way as done for = cpu_ident() >> in the same function, as both cpuid and control registers are = 32-bit.. >> This issue causes users of identcpu-v4 to incorrectly report things = such as >> icache status (bit 12 in cpu control register) and basically = anything >> defined in bits above bit 7 :-) >> Reviewed by: manu >> Sponsored by: Smartcom - Bulgaria AD >> Differential Revision: https://reviews.freebsd.org/D9460 >>=20 >> Modified: >> head/sys/arm/arm/identcpu-v4.c >>=20 >> Modified: head/sys/arm/arm/identcpu-v4.c >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/arm/arm/identcpu-v4.c Mon Feb 6 14:41:34 2017 = (r313342) >> +++ head/sys/arm/arm/identcpu-v4.c Mon Feb 6 14:58:24 2017 = (r313343) >> @@ -294,8 +294,7 @@ u_int cpu_pfr(int num) >> void >> identify_arm_cpu(void) >> { >> - u_int cpuid; >> - u_int8_t ctrl; >> + u_int cpuid, ctrl; >> int i; >> ctrl =3D cpu_get_control(); >> _______________________________________________ >> svn-src-all@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/svn-src-all >> To unsubscribe, send any mail to = "svn-src-all-unsubscribe@freebsd.org"