From owner-svn-src-all@freebsd.org Fri Jul 20 07:16:30 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 40E771034F70; Fri, 20 Jul 2018 07:16:30 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DBA1971288; Fri, 20 Jul 2018 07:16:29 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id B03495045; Fri, 20 Jul 2018 07:16:29 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w6K7GTtA079642; Fri, 20 Jul 2018 07:16:29 GMT (envelope-from delphij@FreeBSD.org) Received: (from delphij@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id w6K7GT16079640; Fri, 20 Jul 2018 07:16:29 GMT (envelope-from delphij@FreeBSD.org) Message-Id: <201807200716.w6K7GT16079640@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: delphij set sender to delphij@FreeBSD.org using -f From: Xin LI Date: Fri, 20 Jul 2018 07:16:29 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r336541 - head/lib/libcrypt X-SVN-Group: head X-SVN-Commit-Author: delphij X-SVN-Commit-Paths: head/lib/libcrypt X-SVN-Commit-Revision: 336541 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jul 2018 07:16:30 -0000 Author: delphij Date: Fri Jul 20 07:16:28 2018 New Revision: 336541 URL: https://svnweb.freebsd.org/changeset/base/336541 Log: libcrypt: There is no need to clear message digest context after they are finialized after r336539, so do not do it. Submitted by: David CARLIER MFC after: 1 month (after r336539) Differential Revision: https://reviews.freebsd.org/D16059 Modified: head/lib/libcrypt/crypt-sha256.c head/lib/libcrypt/crypt-sha512.c Modified: head/lib/libcrypt/crypt-sha256.c ============================================================================== --- head/lib/libcrypt/crypt-sha256.c Fri Jul 20 07:07:27 2018 (r336540) +++ head/lib/libcrypt/crypt-sha256.c Fri Jul 20 07:16:28 2018 (r336541) @@ -239,8 +239,6 @@ crypt_sha256(const char *key, const char *salt, char * memset(temp_result, '\0', sizeof(temp_result)); memset(p_bytes, '\0', key_len); memset(s_bytes, '\0', salt_len); - memset(&ctx, '\0', sizeof(ctx)); - memset(&alt_ctx, '\0', sizeof(alt_ctx)); return (0); } Modified: head/lib/libcrypt/crypt-sha512.c ============================================================================== --- head/lib/libcrypt/crypt-sha512.c Fri Jul 20 07:07:27 2018 (r336540) +++ head/lib/libcrypt/crypt-sha512.c Fri Jul 20 07:16:28 2018 (r336541) @@ -251,8 +251,6 @@ crypt_sha512(const char *key, const char *salt, char * memset(temp_result, '\0', sizeof(temp_result)); memset(p_bytes, '\0', key_len); memset(s_bytes, '\0', salt_len); - memset(&ctx, '\0', sizeof(ctx)); - memset(&alt_ctx, '\0', sizeof(alt_ctx)); return (0); }