From owner-freebsd-qa@FreeBSD.ORG  Thu Mar  4 07:50:26 2004
Return-Path: <owner-freebsd-qa@FreeBSD.ORG>
Delivered-To: freebsd-qa@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0756516A4CE
	for <qa@hub.freebsd.org>; Thu,  4 Mar 2004 07:50:26 -0800 (PST)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 02A9443D2F
	for <qa@hub.freebsd.org>; Thu,  4 Mar 2004 07:50:26 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.10/8.12.10) with ESMTP id i24FoPbv002505
	for <qa@freefall.freebsd.org>; Thu, 4 Mar 2004 07:50:25 -0800 (PST)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i24FoPII002497;
	Thu, 4 Mar 2004 07:50:25 -0800 (PST)
	(envelope-from gnats)
Date: Thu, 4 Mar 2004 07:50:25 -0800 (PST)
Message-Id: <200403041550.i24FoPII002497@freefall.freebsd.org>
To: qa@FreeBSD.org
From: Peter Pentchev <roam@ringlet.net>
Subject: Re: bin/27483: make sysinstall ask for the keymap at installation
	time
X-BeenThere: freebsd-qa@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Peter Pentchev <roam@ringlet.net>
List-Id: FreeBSD Quality Assurance <freebsd-qa.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-qa>,
	<mailto:freebsd-qa-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-qa>
List-Post: <mailto:freebsd-qa@freebsd.org>
List-Help: <mailto:freebsd-qa-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-qa>,
	<mailto:freebsd-qa-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Mar 2004 15:50:26 -0000

The following reply was made to PR bin/27483; it has been noted by GNATS.

From: Peter Pentchev <roam@ringlet.net>
To: cyrille.lefevre@laposte.net
Cc: bug-followup@FreeBSD.org, freebsd-qa@FreeBSD.org
Subject: Re: bin/27483: make sysinstall ask for the keymap at installation time
Date: Thu, 4 Mar 2004 17:46:21 +0200

 --9amGYk9869ThD9tj
 Content-Type: text/plain; charset=windows-1251
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Thu, Mar 04, 2004 at 04:28:09PM +0100, Cyrille Lefevre wrote:
 > cvs diff against -current (FreeBSD 5.2-CURRENT #1: Sat Jan 31 15:17:05 CE=
 T 2004)
 > anyone to commit this PR ?
 > thanks in advance.
 > =20
 [snip]
 >      /* Begin user dialog at outer menu */
 >      dialog_clear();
 > +    if (getpid() =3D=3D 1)
 > +        dmenuOpen(&MenuSysconsKeymap, &choice, &scroll, &curr, &max, FAL=
 SE);
 >      while (1) {
 
 Just a minor comment: shouldn't RunningAsInit be used here instead of
 a getpid() invocation? :)
 
 G'luck,
 Peter
 
 --=20
 Peter Pentchev	roam@ringlet.net    roam@sbnd.net    roam@FreeBSD.org
 PGP key:	http://people.FreeBSD.org/~roam/roam.key.asc
 Key fingerprint	FDBA FD79 C26F 3C51 C95E  DF9E ED18 B68D 1619 4553
 This sentence contains exactly threee erors.
 
 --9amGYk9869ThD9tj
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.4 (FreeBSD)
 
 iD8DBQFAR09N7Ri2jRYZRVMRAlqKAKCTcAmVGc3Rc6afzhZmrg/Go4Y8OQCeN/ap
 Rfl6hZllFD+ZxsXqxlOhHFk=
 =qPre
 -----END PGP SIGNATURE-----
 
 --9amGYk9869ThD9tj--