From owner-svn-src-all@freebsd.org Thu Apr 18 03:23:34 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CBF7115858B4 for ; Thu, 18 Apr 2019 03:23:33 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6CFC472F96 for ; Thu, 18 Apr 2019 03:23:33 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x841.google.com with SMTP id w5so693109qtb.11 for ; Wed, 17 Apr 2019 20:23:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ewK9keJRP5t4VixrU6IeJSzOmWYHy/kUZx+tMORUx6k=; b=pPevSvl3PCUR6X8u66MjJCNaDmb4/yR7BIv9NLtHdHQHhB6Op/08gZzUwzTwYO8DB5 8UGoHqtdOvKFgPfUSObp/EJ1m6FMrGIXNHC7ecP4zdltPld/H8xlWuWaIA/d3brvQgCx QprZ6JSTVUgdw1tXO40AUfOwE4FPSu7NPGNq5ATk2EF7z+snl0N9h6I31cp9+lFzU0T/ SJKWvNH+Z5hMETcm2zZITThjhE1GlFii5eTHeG1HVX4RP/f/dUuvZOuH+tVOAVHiemyh 49lbKlS/X8uVlbT1cHhyQ5yTUqOFpY7mbQfl3tI5V57XwoGBx2j1fUMF2rjwHSQADqZs jSoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ewK9keJRP5t4VixrU6IeJSzOmWYHy/kUZx+tMORUx6k=; b=LYs92V9NmdZGak9Ggul9hmlPWhyxZEBnOK1GB0+uB5iDVaIyQidSM3A7RwtLcggqPM +nrQ8tZGM4mZ8wXEMTduiDMqwdmTKlazqN2ZkGow9sYGwCb2KjTYhJNAf0iR6xcl6dat PEUC64+RWwk1ONevqwh3wVY2WtbVbWOuPbZ2ELlDN/wYz0smkOjg8hG0/7zXohe62NlI FAXnob8REmgCnmpbSjXGzsXQddP9eF5/G13pf7GJ9QeafCEIY6RGesr0qGUMlQIKeFlQ iv8hTmjdo14sxXY5Ai83rZM2ng+OJ/XaFFJgPmJuXcAsYfiz4sn6R7GWt+YtZmIadvfH xP9A== X-Gm-Message-State: APjAAAUzZ/gSjZAVzTD26E4bHdLS/C9eJCQQXoGQ37bV9I0r5CnzvjWx OFbHj51UT/Bb+FkK7gSFo4cqLPxESD0aaC3kAUQIMA== X-Google-Smtp-Source: APXvYqx0RNSiNB2qxcrqVZir/n3vYHDyTrTP/toP3wA5m/3ZHsvumKdFRzvkumuMha57xPZjTrTudiLbFPgR4UIabEQ= X-Received: by 2002:a0c:ba10:: with SMTP id w16mr75026184qvf.115.1555557812546; Wed, 17 Apr 2019 20:23:32 -0700 (PDT) MIME-Version: 1.0 References: <201904162004.x3GK4N7u019636@repo.freebsd.org> In-Reply-To: From: Warner Losh Date: Wed, 17 Apr 2019 21:23:21 -0600 Message-ID: Subject: Re: svn commit: r346295 - in head/sys: arm/allwinner arm/altera/socfpga arm/amlogic/aml8726 arm/annapurna/alpine arm/broadcom/bcm2835 arm/freescale/imx arm/freescale/vybrid arm/mv arm/nvidia/tegra124 a... To: Andrew Turner Cc: Ian Lepore , Emmanuel Vadot , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 6CFC472F96 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.95 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.95)[-0.950,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Apr 2019 03:23:34 -0000 On Wed, Apr 17, 2019 at 12:06 PM Andrew Turner wrote= : > > > On 17 Apr 2019, at 17:52, Ian Lepore wrote: > > On Wed, 2019-04-17 at 11:23 +0200, Andrew Turner wrote: > > On 16 Apr 2019, at 22:04, Emmanuel Vadot wrote: > > Author: manu > Date: Tue Apr 16 20:04:22 2019 > New Revision: 346295 > URL: https://svnweb.freebsd.org/changeset/base/346295 > > Log: > arm: Add kern_clocksource.c directly in files.arm > > This files is needed and included in all our config so move it to > a common > location. > > MFC after: 2 weeks > > > ... > > Modified: head/sys/conf/files.arm > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- head/sys/conf/files.arm Tue Apr 16 19:46:02 2019 (r346294) > +++ head/sys/conf/files.arm Tue Apr 16 20:04:22 2019 (r346295) > @@ -11,6 +11,9 @@ cloudabi32_vdso_blob.o optional com > pat_cloudabi32 \ > no-implicit-rule \ > clean "cloudabi32_vdso_blob.o" > # > + > +kern/kern_clocksource.c standard > > > Could this be moved from the various files.* to files? It seems we > define it as standard on all architectures. > > > > I thought mips still had some variants that didn't implement event > timers. That's why this stuff was ever in arch-specific files, arm and > mips had some flavors without ET support. > > > I think it used to be the case on arm. A grep seems to think it=E2=80=99s= enabled > on all architectures now: > > grep kern_clocksource files.* > files.amd64:kern/kern_clocksource.c standard > files.arm:kern/kern_clocksource.c standard > files.arm64:kern/kern_clocksource.c standard > files.i386:kern/kern_clocksource.c standard > files.mips:kern/kern_clocksource.c standard > files.powerpc:kern/kern_clocksource.c standard > files.riscv:kern/kern_clocksource.c standard > files.sparc64:kern/kern_clocksource.c standard > Looks like it can be hoisted and required for all new architectures. Warner