From owner-freebsd-ports-bugs@freebsd.org Mon Jun 29 01:13:35 2015 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6884F98C2AD for ; Mon, 29 Jun 2015 01:13:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4C5CD1FB3 for ; Mon, 29 Jun 2015 01:13:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5T1DZnv025162 for ; Mon, 29 Jun 2015 01:13:35 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 172964] [bsd.port.mk] USE_GITHUB feature not fully implemented Date: Mon, 29 Jun 2015 01:13:35 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Documentation X-Bugzilla-Component: Documentation X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: FreeBSD@ShaneWare.Biz X-Bugzilla-Status: Open X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status product resolution component Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jun 2015 01:13:35 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D172964 FreeBSD@ShaneWare.Biz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Closed |Open Product|Ports & Packages |Documentation Resolution|FIXED |--- Component|Individual Port(s) |Documentation --- Comment #8 from FreeBSD@ShaneWare.Biz --- Yes having one item without a group name does fix this, thanks, but I will change the product to documentation for some improvement. Looking through the docs... there isn't any github specific info yet, so I = was using the DISTFILES info... In the porters handbook in 5.4.7.1 paragraph 3 - To support this, each entry in DISTFILES may be followed by a colon and a = =E2=80=9Ctag name=E2=80=9D. Each site listed in MASTER_SITES is then followed by a colon= , and the tag that indicates which distribution files are downloaded from this site. Example 5.4 MASTER_SITES=3D ftp://ftp1.example.com/:source1 \ http://www.example.com/:source2 DISTFILES=3D source1.tar.gz:source1 \ source2.tar.gz:source2 Example 5.5 MASTER_SITES=3D ftp://ftp.example.com/:source1 \ http://www.example.com/:source2 DISTFILES=3D source1.tar.gz:source1 \ source2.tar.gz:source2 \ source3.tar.gz:source2 That is the most visible section and states "Each site listed in MASTER_SIT= ES is then followed by a colon, and the tag..." which implies that each item g= ets a non-default group name (as I was trying). Later, example 5.7 does show it= ems using no group and DEFAULT group, this is getting into more detailed info a= nd could be skipped by many people. Also 5.4.7.2 -> 3 says Elements without a postfix are groupless, they all belong to the special gr= oup DEFAULT. Any elements postfixed with DEFAULT, is just being redundant unles= s an element belongs to both DEFAULT and other groups at the same time (check it= em 5). These examples are equivalent but the first one is preferred: MASTER_SITES=3D alpha MASTER_SITES=3D alpha:DEFAULT Followed by section 4 - Groups are not exclusive, an element may belong to several different groups= at the same time and a group can either have either several different elements= or none at all. The double "either" could be changed there. I guess this is the closest part to what you refer, but I don't see mention= of "don't add a group name to one element" or that one element "must be DEFAUL= T or nameless", in fact it states "a group can ... have ... none at all". Before the GH_* group support was added I was using MASTER_SITES and DISTFI= LES setup with the same four groups I applied to the GH_* variables. That impli= es that the GH_* variables differ from the other variables supporting groups. If you are adjusting the docs maybe you could also add some info for multip= le parts to 5.4.2.3. USE_GITHUB. If requiring one DEFAULT group is unique to USE_GITHUB I think this would be the best place to explain that. github variables could also be added to the variable list in 5.4.7.2 -> 7 I think that is all the relevant parts of the porters handbook. --=20 You are receiving this mail because: You are the assignee for the bug.=