Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 8 Jan 2020 13:49:29 -0700
From:      Warner Losh <imp@bsdimp.com>
To:        Ed Maste <emaste@freebsd.org>
Cc:        src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>,  svn-src-head <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r356514 - head/share/mk
Message-ID:  <CANCZdfpLJQVDXy11aJxpdfRkksmW3SYZmpvDfrD-vjso=j4Pcg@mail.gmail.com>
In-Reply-To: <202001082045.008KjIlD095701@repo.freebsd.org>
References:  <202001082045.008KjIlD095701@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 8, 2020 at 1:45 PM Ed Maste <emaste@freebsd.org> wrote:

> Author: emaste
> Date: Wed Jan  8 20:45:18 2020
> New Revision: 356514
> URL: https://svnweb.freebsd.org/changeset/base/356514
>
> Log:
>   src.opts.mk: enable LLVM_UNWIND by default for all archs
>
>   Only sparc64 did not enable LLVM_LIBUNWIND. After r356513 LLVM_LIBUNWIND
>   should at least build on sparc64. The old DWARF unwinder will be removed
>   along with GCC 4.2.1 in the near future, so switch sparc64 to use LLVM's
>   unwinder in advance of the removal.  Someone with access to the obsolete
>   sparc64 hardware supported by FreeBSD will have to test, and investigate
>   any failures. I will gladly help, but I don't have any suitable hardware
>   myself.
>
>   PR:           233405
>

One fewer option defaults based on Arch! And there was much rejoicing.

Warner


> Modified:
>   head/share/mk/src.opts.mk
>
> Modified: head/share/mk/src.opts.mk
>
> ==============================================================================
> --- head/share/mk/src.opts.mk   Wed Jan  8 20:37:03 2020        (r356513)
> +++ head/share/mk/src.opts.mk   Wed Jan  8 20:45:18 2020        (r356514)
> @@ -129,6 +129,7 @@ __DEFAULT_YES_OPTIONS = \
>      LIBPTHREAD \
>      LIBTHR \
>      LLVM_COV \
> +    LLVM_LIBUNWIND \
>      LLVM_TARGET_ALL \
>      LOADER_GELI \
>      LOADER_LUA \
> @@ -315,11 +316,6 @@ BROKEN_OPTIONS+=BINUTILS BINUTILS_BOOTSTRAP GCC GCC_BO
>  .endif
>  .if ${__T:Mriscv*} != ""
>  BROKEN_OPTIONS+=OFED
> -.endif
> -.if ${__T} != "sparc64"
> -__DEFAULT_YES_OPTIONS+=LLVM_LIBUNWIND
> -.else
> -__DEFAULT_NO_OPTIONS+=LLVM_LIBUNWIND
>  .endif
>  .if ${__TT} != "mips" && ${__T} != "powerpc" && ${__T} != "powerpcspe" &&
> \
>      ${__T} != "sparc64"
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpLJQVDXy11aJxpdfRkksmW3SYZmpvDfrD-vjso=j4Pcg>