From owner-svn-src-projects@freebsd.org  Thu Feb 21 07:56:39 2019
Return-Path: <owner-svn-src-projects@freebsd.org>
Delivered-To: svn-src-projects@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5C78A14FB6A5
 for <svn-src-projects@mailman.ysv.freebsd.org>;
 Thu, 21 Feb 2019 07:56:39 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id C842494A4C;
 Thu, 21 Feb 2019 07:56:38 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x1L7uYnM019245;
 Wed, 20 Feb 2019 23:56:34 -0800 (PST)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id x1L7uYNs019244;
 Wed, 20 Feb 2019 23:56:34 -0800 (PST) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201902210756.x1L7uYNs019244@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r344420 - in projects/import-googletest-1.8.1:
 lib/googletest/gmock lib/googletest/gtest share/mk
In-Reply-To: <F6EA4AB0-2B53-493B-8762-62C76F797E5F@gmail.com>
To: "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
Date: Wed, 20 Feb 2019 23:56:34 -0800 (PST)
CC: rgrimes@freebsd.org, Enji Cooper <ngie@freebsd.org>,
 src-committers@freebsd.org, svn-src-projects@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-Rspamd-Queue-Id: C842494A4C
X-Spamd-Bar: ------
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-6.90 / 15.00];
 NEURAL_HAM_MEDIUM(-1.00)[-1.000,0];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[];
 NEURAL_HAM_SHORT(-0.90)[-0.904,0]
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
 tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects/>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Feb 2019 07:56:39 -0000

> > On Feb 20, 2019, at 10:23 PM, Rodney W. Grimes <freebsd@pdx.rh.CN85.dnsmgr.net> wrote:
> > 
> >> Author: ngie
> >> Date: Thu Feb 21 04:47:44 2019
> >> New Revision: 344420
> >> URL: https://svnweb.freebsd.org/changeset/base/344420 <https://svnweb.freebsd.org/changeset/base/344420>
> >> 
> >> Log:
> >>  Use gmock/gtest headers when PRIVATELIB is defined
> >> 
> >>  The move to /usr/include/private prefixed paths seems to require a bit more
> >>  effort in order to compile programs.
> >> 
> >>  Install the headers to /usr/include/private/g{mock,test}/... and automatically
> >>  include /usr/include/private in GTESTS_CXXFLAGS to make compilation seamless. I
> >>  will work on the more global problem later with @bdrewery.
> > 
> > Is this also hooked in to a (cd /usr/src/ && make includes) if gtest is enabled?
> 
> To clarify, are you asking if the headers are installed via ?make includes??
Correct

> 
> Yes, they were before and after this commit. The only thing that?s changed is where they are installed (/usr/include/g{mock,test} -> /usr/include/private/g{mock,test}).
Great, thanks

-- 
Rod Grimes                                                 rgrimes@freebsd.org