From owner-svn-src-all@freebsd.org Sat Sep 16 03:46:49 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 504A0E22654; Sat, 16 Sep 2017 03:46:49 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail110.syd.optusnet.com.au (mail110.syd.optusnet.com.au [211.29.132.97]) by mx1.freebsd.org (Postfix) with ESMTP id 8361A65309; Sat, 16 Sep 2017 03:46:48 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from [192.168.0.102] (c110-21-101-228.carlnfd1.nsw.optusnet.com.au [110.21.101.228]) by mail110.syd.optusnet.com.au (Postfix) with ESMTPS id F04FC10408E; Sat, 16 Sep 2017 13:46:38 +1000 (AEST) Date: Sat, 16 Sep 2017 13:46:37 +1000 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Scott Long cc: Sean Bruno , Stephen Hurd , Cy Schubert , Ngie Cooper , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r323516 - in head/sys: dev/bnxt dev/e1000 kern net sys In-Reply-To: <1EBD0641-002D-409C-B18E-AAB5FCDECEBA@samsco.org> Message-ID: <20170916124826.P1107@besplex.bde.org> References: <201709130711.v8D7BlTS003204@slippy.cwsent.com> <48654d1f-4cc7-da05-7a73-ef538b431560@freebsd.org> <1EBD0641-002D-409C-B18E-AAB5FCDECEBA@samsco.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.2 cv=bc8baKHB c=1 sm=1 tr=0 a=PalzARQSbocsUSjMRkwAPg==:117 a=PalzARQSbocsUSjMRkwAPg==:17 a=kj9zAlcOel0A:10 a=6I5d2MoRAAAA:8 a=NZlVo5omRyg7tE8A30gA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Sep 2017 03:46:49 -0000 On Fri, 15 Sep 2017, Scott Long wrote: >> On Sep 13, 2017, at 9:12 AM, Sean Bruno wrote: >> >>>>> #blamebruno A large burden. >>>>> Reviewed by: sbruno >>>>> Approved by: sbruno (mentor) >>>>> Sponsored by: Limelight Networks >>>>> Differential Revision: https://reviews.freebsd.org/D12235 >>>> >>>> *gasps at the LoC count and number of changed drivers* >>>> >>>> Could someone please better break this up in the future..? >> >> This ridiculous loc was due to the amount of restructuring needed to get >> us back to being in sync with our development. The future will not have >> this big of a commit/change and should be more bite/fun sized. >> >> The #blamebruno tag in the commit log was to indicate that this was not >> something Stephen was doing on his own, but was something that I had >> induced over the last few months during testing. > > This breaks my system. I prior to this commit, I had igb0 and igb1. Now I > only have igb0, and it\xe2]x80\x99s like igb1 isn\xe2\x80\x99tt even trying to attach. Unfortunately, > this breaks my nfsroot setup, so I need to roll back my tree. Please let me > know if there\xe2\x80\x99ss anything I can provide to help debugging. It gives lesser breakage here: - with an old PCI em, an error that occur every few makeworlds over nfs now hang the hardware. It used to be recovered from afger about 10 seconds. This only happened once. I then applied my old fix which ignores the error better so as to recover from it immediately. This seems to work as before. - with a newer PCI-e em, throughput as measured by netblast is down by more that a factor of 2 since last month. Bruce