From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Nov 14 12:30:02 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 702081065674 for ; Fri, 14 Nov 2008 12:30:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 549AA8FC13 for ; Fri, 14 Nov 2008 12:30:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id mAECU1br091233 for ; Fri, 14 Nov 2008 12:30:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id mAECU1j0091232; Fri, 14 Nov 2008 12:30:01 GMT (envelope-from gnats) Resent-Date: Fri, 14 Nov 2008 12:30:01 GMT Resent-Message-Id: <200811141230.mAECU1j0091232@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Elvis Stansvik Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3E88E106568C for ; Fri, 14 Nov 2008 12:24:21 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 35AF28FC12 for ; Fri, 14 Nov 2008 12:24:21 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id mAECOKXm079065 for ; Fri, 14 Nov 2008 12:24:20 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id mAECOKFw079043; Fri, 14 Nov 2008 12:24:20 GMT (envelope-from nobody) Message-Id: <200811141224.mAECOKFw079043@www.freebsd.org> Date: Fri, 14 Nov 2008 12:24:20 GMT From: Elvis Stansvik To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/128866: Add patch from upstream to fix segfault in modperl on x86 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Nov 2008 12:30:02 -0000 >Number: 128866 >Category: ports >Synopsis: Add patch from upstream to fix segfault in modperl on x86 >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Nov 14 12:30:01 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Elvis Stansvik >Release: 7.0 >Organization: >Environment: FreeBSD franz.franzkafe.se 7.0-RELEASE-p1 FreeBSD 7.0-RELEASE-p1 #2: Tue May 20 20:31:14 CEST 2008 root@franz.franzkafe.se:/usr/obj/usr/src/sys/GENERIC i386 >Description: Add a patch from upstream that fixes a segfault on startup in the Perl module. The fix is in upstream SVN trunk and can be removed when the next ZNC is released [1]. Regards, Elvis [1] http://znc.svn.sourceforge.net/viewvc/znc?view=rev&revision=1237 >How-To-Repeat: Run ZNC on i386 (and maybe other platforms) with the modperl module enabled. It will segfault in the OnLoad method in modperl.cpp. >Fix: See attached patch. Patch attached with submission follows: diff -ruN znc.bak/Makefile znc/Makefile --- znc.bak/Makefile 2008-11-14 13:01:18.000000000 +0100 +++ znc/Makefile 2008-11-14 13:06:49.000000000 +0100 @@ -7,6 +7,7 @@ PORTNAME= znc PORTVERSION= 0.060 +PORTREVISION= 1 CATEGORIES= irc ipv6 MASTER_SITES= SF diff -ruN znc.bak/files/patch-modules-modperl.cpp znc/files/patch-modules-modperl.cpp --- znc.bak/files/patch-modules-modperl.cpp 1970-01-01 01:00:00.000000000 +0100 +++ znc/files/patch-modules-modperl.cpp 2008-11-14 13:06:03.000000000 +0100 @@ -0,0 +1,13 @@ +--- modules/modperl.cpp.orig 2008-11-14 13:02:05.000000000 +0100 ++++ modules/modperl.cpp 2008-11-14 13:03:02.000000000 +0100 +@@ -984,8 +984,8 @@ + bool CModPerl::OnLoad(const CString & sArgs, CString & sMessage) + { + int iArgc = 5; +- const char * pArgv[] = { "", "-e", "0", "-T", "-w", NULL }; +- PERL_SYS_INIT3( &iArgc, (char ***)&pArgv, &environ ); ++ char * pArgv[] = { "", "-e", "0", "-T", "-w", NULL }; ++ PERL_SYS_INIT3( &iArgc, &pArgv, &environ ); + m_pPerl = perl_alloc(); + perl_construct(m_pPerl); + >Release-Note: >Audit-Trail: >Unformatted: