Date: Wed, 7 Mar 2012 12:39:14 +0530 From: Gautam <list@execve.net> To: freebsd-ports@freebsd.org, dinoex@freebsd.org Subject: Re: graphics/png does not build with lang/gcc Message-ID: <CAD9pFYAn1swqP8Qrh4MwNUnaDeEA_enjpTVAz28tsajU_cZi9g@mail.gmail.com> In-Reply-To: <CAD9pFYBsXT6qsUYOOeiZX%2B9nv5D31XwSgVymB%2B92gAsEP-Z3KA@mail.gmail.com> References: <CAD9pFYAY0Lu9v7ApS0zt4WjYOKMrTMrJ0nTq4viCEAJY1MJzpQ@mail.gmail.com> <CAD9pFYDS06WWU%2BwB%2Bs15iOYzCuDC_9HmirTZw19g1-kCgJHVhA@mail.gmail.com> <1329928804776-5505596.post@n5.nabble.com> <CAD9pFYAUOsMqNbTEQiKEpuXfRzqs8%2Bc0W9iT_14HzQD88iENjA@mail.gmail.com> <1330200221656-5515744.post@n5.nabble.com> <1330200337495-5515746.post@n5.nabble.com> <1330200824033-5515762.post@n5.nabble.com> <CAD9pFYBsXT6qsUYOOeiZX%2B9nv5D31XwSgVymB%2B92gAsEP-Z3KA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, Adding dinoex (Maintainer of graphics/png). On Mon, Feb 27, 2012 at 9:51 PM, Gautam <list@execve.net> wrote: > > >> Still didnt work for me -- did another buildworld and retried to check if > there was something else messed up. > > I am moving back to base gcc for now. Waiting for redports lang/gcc > backend to come up ;) and will check this again on 8-stable as well. > > > I have tested this on three systems now -- 8.2-REL (fresh), 9.0-REL(fresh) and 9.0-STABLE (original system). The problem is visible on all of these releases. I have now root-caused this problem (that graphics/png does not build with lang/gcc on 8.2 or 9.0), proposed solution solves it on all three systems. Similar PRs were found: 155334 and 141238. Solution is to add -lssp_nonshared to LDADD in work/libpng-1.4.8/scripts/makefile.freebsd. LDADD+= -lm -lz -lssp_nonshared However, I suppose this be conditional on OSVERSION >= 800000 so that it doesnt break older FreeBSD releases but I am not sure of the final solution to this -- maybe add a conditional patch ? How is that usually done? Should I file a PR for this? Thanks Gautam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAD9pFYAn1swqP8Qrh4MwNUnaDeEA_enjpTVAz28tsajU_cZi9g>