From owner-freebsd-ports@FreeBSD.ORG Wed Mar 7 07:09:15 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2C221106564A; Wed, 7 Mar 2012 07:09:15 +0000 (UTC) (envelope-from execve@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id D16FB8FC0A; Wed, 7 Mar 2012 07:09:14 +0000 (UTC) Received: by iahk25 with SMTP id k25so11080405iah.13 for ; Tue, 06 Mar 2012 23:09:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; bh=QlYBC+2D6ec2hAE2clunLYcPjvnQg3eZhl1YMPxughU=; b=D34nJM0bq/WkXGV3UOPAphVLt/VKdUWVQAKK8SLWV3YROjU4SXGHVW2efGV72oGMKI FInmktupss6imIi90ssw1CPa8XZ5gpAwTNNS3WUrb7bnqa+Qfw5aufw8fW2lD9ROGXoK J03zdjnAZqvpqzaxPDelpndFl4hhCXZ1RrhvYr4GzJgh74N3FQ32Jc2xowhr9xd3qR8v wZODnHE8MPTnN/MsiCtdYAyPQgGpBoI1c27Rs5kNbaBZ6uWgQtZCXuwIuzPjiqUqIwMn 0HlHcJNPDfLbzWvvYFnIVLgCkXQ/IuLVQubL9vgTsX8KZXd1EvXOVSUWwMv040oE1ytm gj0w== MIME-Version: 1.0 Received: by 10.50.156.166 with SMTP id wf6mr11141882igb.20.1331104154493; Tue, 06 Mar 2012 23:09:14 -0800 (PST) Sender: execve@gmail.com Received: by 10.231.102.9 with HTTP; Tue, 6 Mar 2012 23:09:14 -0800 (PST) In-Reply-To: References: <1329928804776-5505596.post@n5.nabble.com> <1330200221656-5515744.post@n5.nabble.com> <1330200337495-5515746.post@n5.nabble.com> <1330200824033-5515762.post@n5.nabble.com> Date: Wed, 7 Mar 2012 12:39:14 +0530 X-Google-Sender-Auth: 91A_2P4r-JjhcWtC0v10Exv6WMY Message-ID: From: Gautam To: freebsd-ports@freebsd.org, dinoex@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Subject: Re: graphics/png does not build with lang/gcc X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2012 07:09:15 -0000 Hi, Adding dinoex (Maintainer of graphics/png). On Mon, Feb 27, 2012 at 9:51 PM, Gautam wrote: > > >> Still didnt work for me -- did another buildworld and retried to check if > there was something else messed up. > > I am moving back to base gcc for now. Waiting for redports lang/gcc > backend to come up ;) and will check this again on 8-stable as well. > > > I have tested this on three systems now -- 8.2-REL (fresh), 9.0-REL(fresh) and 9.0-STABLE (original system). The problem is visible on all of these releases. I have now root-caused this problem (that graphics/png does not build with lang/gcc on 8.2 or 9.0), proposed solution solves it on all three systems. Similar PRs were found: 155334 and 141238. Solution is to add -lssp_nonshared to LDADD in work/libpng-1.4.8/scripts/makefile.freebsd. LDADD+= -lm -lz -lssp_nonshared However, I suppose this be conditional on OSVERSION >= 800000 so that it doesnt break older FreeBSD releases but I am not sure of the final solution to this -- maybe add a conditional patch ? How is that usually done? Should I file a PR for this? Thanks Gautam