From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Jan 17 04:40:38 2005 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 786D516A4CE for ; Mon, 17 Jan 2005 04:40:38 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 36DF243D54 for ; Mon, 17 Jan 2005 04:40:38 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id j0H4echZ092424 for ; Mon, 17 Jan 2005 04:40:38 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.1/8.13.1/Submit) id j0H4ecgK092423; Mon, 17 Jan 2005 04:40:38 GMT (envelope-from gnats) Resent-Date: Mon, 17 Jan 2005 04:40:38 GMT Resent-Message-Id: <200501170440.j0H4ecgK092423@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Colin Percival Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 647E316A4CE for ; Mon, 17 Jan 2005 04:38:31 +0000 (GMT) Received: from hexahedron.daemonology.net (S0106006067227a4a.vc.shawcable.net [24.87.233.42]) by mx1.FreeBSD.org (Postfix) with SMTP id 6EE1743D2F for ; Mon, 17 Jan 2005 04:38:30 +0000 (GMT) (envelope-from cperciva@hexahedron.daemonology.net) Received: (qmail 92630 invoked by uid 1001); 17 Jan 2005 04:38:29 -0000 Message-Id: <20050117043829.92629.qmail@hexahedron.daemonology.net> Date: 17 Jan 2005 04:38:29 -0000 From: Colin Percival To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/76330: editors/openoffice-1.1 calls uname needlessly X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Colin Percival List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jan 2005 04:40:38 -0000 >Number: 76330 >Category: ports >Synopsis: editors/openoffice-1.1 calls uname needlessly >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Jan 17 04:40:37 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Colin Percival >Release: FreeBSD 5.3-SECURITY i386 >Organization: >Environment: System: FreeBSD hexahedron.daemonology.net 5.3-SECURITY FreeBSD 5.3-SECURITY #0: Fri Jan 7 04:09:28 UTC 2005 root@builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC i386 >Description: editors/openoffice-1.1/Makefile generates SIMPLEOSVER by parsing the output of `uname -r`. This is pointless, since the same data can be obtained from the (already generated) OSREL variable. >How-To-Repeat: >Fix: --- oo.diff begins here --- Index: ports/editors/openoffice-1.1/Makefile =================================================================== RCS file: /home/pcvs/ports/editors/openoffice-1.1/Makefile,v retrieving revision 1.173 diff -u -p -r1.173 Makefile --- ports/editors/openoffice-1.1/Makefile 16 Jan 2005 08:47:09 -0000 1.173 +++ ports/editors/openoffice-1.1/Makefile 17 Jan 2005 04:32:36 -0000 @@ -82,7 +82,7 @@ RELEASE_NR= ${PORTVERSION} INSTALLATION_BASEDIR= OpenOffice.org${RELEASE_NR} EXECBASE= openoffice.org-${RELEASE_NR} DIST_SUBDIR= openoffice1.1 -SIMPLEOSVER!= ${UNAME} -r | ${SED} -e 's/\.//g' | ${SED} -e 's/-.*//' +SIMPLEOSVER= ${OSREL:C/\.//g} PACKAGE_BASENAME= OOo_${PORTVERSION}_${OPSYS}${SIMPLEOSVER}Intel # FIXME (Somehow INDEX build fails) --- oo.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: