From owner-freebsd-current@FreeBSD.ORG Mon Aug 1 14:11:32 2005 Return-Path: X-Original-To: current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DA0E616A41F; Mon, 1 Aug 2005 14:11:32 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id 70BD443D48; Mon, 1 Aug 2005 14:11:32 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from [10.50.40.201] (Not Verified[65.202.103.25]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Mon, 01 Aug 2005 10:26:07 -0400 From: John Baldwin To: current@FreeBSD.org Date: Mon, 1 Aug 2005 10:12:01 -0400 User-Agent: KMail/1.8 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200508011012.01917.jhb@FreeBSD.org> Cc: rwatson@FreeBSD.org Subject: [PATCH] pcn(4) locking fixes, please test! X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Aug 2005 14:11:33 -0000 One of my boxes at home has a pcn(4) card in it and I noticed it was still running with Giant, so I fixed up the locking in the driver so that it should be MP safe now. However, the box I have is running 5.4 and I didn't get a chance to try and run a HEAD kernel on it to see how it fared, so I would appreciate it if folks with pcn(4) hardware could test these patches. The first patch fixes up the locking, converts from timeout(9) to callout(9), etc. but doesn't actually mark the driver as being MP safe so that the locking changes can be tested first while still running the driver under Giant. The second patch marks the driver as MP safe so that it doesn't need Giant anymore. http://people.freebsd.org/~jhb/patches/pcn_locking_fixes.patch http://people.freebsd.org/~jhb/patches/pcn_mpsafe.patch -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org