From owner-svn-src-all@FreeBSD.ORG Fri Aug 16 17:13:18 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id B2B2D9E8; Fri, 16 Aug 2013 17:13:18 +0000 (UTC) (envelope-from davide.italiano@gmail.com) Received: from mail-vc0-x22e.google.com (mail-vc0-x22e.google.com [IPv6:2607:f8b0:400c:c03::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 2843C2514; Fri, 16 Aug 2013 17:13:18 +0000 (UTC) Received: by mail-vc0-f174.google.com with SMTP id gd11so1638880vcb.33 for ; Fri, 16 Aug 2013 10:13:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=HqO5Hs0Gk1PnpdgY1h/gf4TuSZBmyVg77VLWiVHw3h4=; b=zfnbC2Wst+BfbaeeTl2C/Z7JxU/FgQPZ+M2U7FCR/9B2gixtFS5OD3sJWu9OxIrhZF a5GJPvy0DVh5O+a6FwAe/h3C+cnQXnCZwf0xojH+WSeFRNR/LHGyDjf53BX/QF4wRC1i LSEVbC0a0or7Cnj9YI3ecPUQDjeBhoP3L8nO7gseplURcBJGSi+SlAggX/VI+d2wdAIW 9Q4oE9gR0m/y8vuiFyLu4/mcwJTXDu0UQ2WIuS7H8V1+YxXXE1lGB1W0cro5cqDGlhaD v4hmTLK3vf9zZSdiPSbSTS+MoY0j64q46exLFJ1lDj0Cqp7VpE9GYwDRTdDlC1sCy9i/ ipvg== MIME-Version: 1.0 X-Received: by 10.220.91.16 with SMTP id k16mr2190821vcm.21.1376673197152; Fri, 16 Aug 2013 10:13:17 -0700 (PDT) Sender: davide.italiano@gmail.com Received: by 10.220.21.140 with HTTP; Fri, 16 Aug 2013 10:13:16 -0700 (PDT) In-Reply-To: <20130816170027.GA1888@charmander.sandvine.com> References: <201308140042.r7E0gMtf054550@svn.freebsd.org> <201308140819.13854.jhb@freebsd.org> <20130816170027.GA1888@charmander.sandvine.com> Date: Fri, 16 Aug 2013 19:13:16 +0200 X-Google-Sender-Auth: CvHfX_7SEvvfdbb7c-b7pcLNg6A Message-ID: Subject: Re: svn commit: r254309 - in head: share/man/man9 sys/cddl/contrib/opensolaris/uts/common/dtrace sys/cddl/dev/dtrace sys/cddl/dev/sdt sys/kern sys/sys From: Davide Italiano To: Mark Johnston Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, John Baldwin X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2013 17:13:18 -0000 [trim old mails] > diff --git a/sys/sys/pmckern.h b/sys/sys/pmckern.h > index e3e18a6..90585de 100644 > --- a/sys/sys/pmckern.h > +++ b/sys/sys/pmckern.h > @@ -51,13 +51,11 @@ > #define PMC_FN_CSW_IN 2 > #define PMC_FN_CSW_OUT 3 > #define PMC_FN_DO_SAMPLES 4 > -#define PMC_FN_KLD_LOAD 5 > -#define PMC_FN_KLD_UNLOAD 6 > -#define PMC_FN_MMAP 7 > -#define PMC_FN_MUNMAP 8 > -#define PMC_FN_USER_CALLCHAIN 9 > -#define PMC_FN_USER_CALLCHAIN_SOFT 10 > -#define PMC_FN_SOFT_SAMPLING 11 > +#define PMC_FN_MMAP 5 > +#define PMC_FN_MUNMAP 6 > +#define PMC_FN_USER_CALLCHAIN 7 > +#define PMC_FN_USER_CALLCHAIN_SOFT 8 > +#define PMC_FN_SOFT_SAMPLING 9 > I've skimmed over your patch quickly so I could miss something, but I worry about this change breaking the KBI. Does this make sense for you? > #define PMC_HR 0 /* Hardware ring buffer */ > #define PMC_SR 1 /* Software ring buffer */ > Thanks, -- Davide "There are no solved problems; there are only problems that are more or less solved" -- Henri Poincare