Date: Fri, 1 May 2015 00:56:28 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Kris Moore <kris@pcbsd.org> Cc: Jan Beich <jbeich@FreeBSD.org>, Kris Moore <kmoore@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r385072 - head/x11/lumina Message-ID: <20150430225628.GP13141@ivaldir.etoilebsd.net> In-Reply-To: <5542B287.8000707@pcbsd.org> References: <201504302212.t3UMClq7091335@svn.freebsd.org> <h9rx-w7w6-wny@FreeBSD.org> <20150430225013.GO13141@ivaldir.etoilebsd.net> <5542B287.8000707@pcbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--OmL7C/BU0IhhC9Of
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, Apr 30, 2015 at 06:53:59PM -0400, Kris Moore wrote:
> On 04/30/2015 18:50, Baptiste Daroussin wrote:
> > On Fri, May 01, 2015 at 12:47:37AM +0200, Jan Beich wrote:
> >> Kris Moore <kmoore@FreeBSD.org> writes:
> >>
> >>> -PORTVERSION=3D 0.8.3.${GITVERSION}
> >>> -PORTEPOCH=3D 1
> >>> +PORTVERSION=3D 0.8.4
> >>> +PORTREVISION=3D 1
> >> PORTEPOCH cannot be removed.
> >>
> >> $ portlint -C
> >> FATAL: Makefile: lumina-0.8.4_1 < lumina-0.8.3.1427733141,1. Choose an=
other PORTVERSION or bump PORTEPOCH.
> >>
> >>> +USE_GITHUB=3D yes
> >>> +GH_ACCOUNT=3D pcbsd
> >>> +GH_COMMIT=3D 01bfb64
> >>> +GH_TAGNAME=3D v0.8.4-Release-P1
> >> GH_COMMIT is deprecated and GH_TAGNAME is often a superset of PORTVERS=
ION.
> >> Also, spaces instead of tabs.
> >>
> >> $ portlint -C
> >> FATAL: Makefile: [43]: use a tab (not space) after a variable name
> >> FATAL: Makefile: [44]: use a tab (not space) after a variable name
> >> FATAL: Makefile: [45]: use a tab (not space) after a variable name
> >> FATAL: Makefile: [46]: use a tab (not space) after a variable name
> >>
> >> Index: x11/lumina/Makefile
> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> >> --- x11/lumina/Makefile (revision 385072)
> >> +++ x11/lumina/Makefile (working copy)
> >> @@ -3,7 +3,9 @@
> >> =20
> >> PORTNAME=3D lumina
> >> PORTVERSION=3D 0.8.4
> >> -PORTREVISION=3D 1
> >> +DISTVERSIONPREFIX=3Dv
> >> +DISTVERSIONSUFFIX=3D-Release-P1
> >> +PORTEPOCH=3D 1
> >> CATEGORIES=3D x11
> >> =20
> >> MAINTAINER=3D kmoore@FreeBSD.org
> >> @@ -40,10 +42,8 @@ USE_LDCONFIG=3D yes
> >> USE_QT5=3D core gui network svg linguist multimedia imageformats \
> >> buildtools x11extras
> >> USES=3D qmake tar:bzip2
> >> -USE_GITHUB=3D yes
> >> -GH_ACCOUNT=3D pcbsd
> >> -GH_COMMIT=3D 01bfb64
> >> -GH_TAGNAME=3D v0.8.4-Release-P1
> >> +USE_GITHUB=3D yes
> >> +GH_ACCOUNT=3D pcbsd
> >> =20
> >> QMAKE_ARGS=3D CONFIG+=3D"configure"
> >> =20
> >> Index: x11/lumina/distinfo
> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> >> --- x11/lumina/distinfo (revision 385072)
> >> +++ x11/lumina/distinfo (working copy)
> >> @@ -1,2 +1,2 @@
> >> -SHA256 (lumina-0.8.4.tar.bz2) =3D 311114964e900132a09e9acac46958da09d=
7ffb12a3e1d7653147b8952f658f0
> >> -SIZE (lumina-0.8.4.tar.bz2) =3D 23261871
> >> +SHA256 (pcbsd-lumina-v0.8.4-Release-P1_GH0.tar.bz2) =3D 5d54f60a534ea=
8d92259a6f57074173d9721492b7148a5fa5bcf8894beeffaf6
> >> +SIZE (pcbsd-lumina-v0.8.4-Release-P1_GH0.tar.bz2) =3D 23261876
> >
> > 100% agree with Jan + remove tar:bzip2 github only provides tar.gz even=
is you
> > do ask a bzip2 :)
> >
> > Best regards,
> > Bapt
>=20
> Fixing it now. Don't know why I didn't see the GH_COMMIT error. My tree
> is about a week and half old? Did that warning just go in?
>=20
>=20
> --=20
> Kris Moore
> PC-BSD Software / iXsystems
> Enterprise Storage & Servers Driven By Open Source
>=20
Do you have DEVELOPER=3Dyes in your make.conf
Best regards,
Bapt
--OmL7C/BU0IhhC9Of
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iEYEARECAAYFAlVCsxwACgkQ8kTtMUmk6ExxiwCfbj9v8dgovJ7KGQx/cI5rmEpb
tGAAnRyqSvdg9zhZO7ZymK60K5QKkVJ+
=Caji
-----END PGP SIGNATURE-----
--OmL7C/BU0IhhC9Of--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150430225628.GP13141>