Date: Sun, 12 May 2019 16:48:16 +1000 From: Kubilay Kocak <koobs@FreeBSD.org> To: Adriaan de Groot <adridg@freebsd.org>, Tobias Kortkamp <tobik@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r501243 - head/net/freeswitch Message-ID: <175048cd-c50a-5f6d-ce21-29aa0cf0d4b6@FreeBSD.org> In-Reply-To: <1807231.EnoYUHA41c@beastie.bionicmutton.org> References: <201905110955.x4B9teAQ032692@repo.freebsd.org> <1807231.EnoYUHA41c@beastie.bionicmutton.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/05/2019 8:43 pm, Adriaan de Groot wrote:
> On Saturday, 11 May 2019 11:55:40 CEST Tobias Kortkamp wrote:
>> net/freeswitch: Fix build and disable -Werror to stop collecting -Wno-*
>> flags
>
> Why not patch it to do the right thing? With patches you might even be able to
> move things upstream, .. or chase the latest release, since upstream seems to
> be doing monthlies now (there is a 1.8.5, which still contains the same
> problem).
>
> The underlying error is that the code is doing, basically,
>
> strlen("derp"+1)
>
> where it's adding one to a string constant; clang helpfully (? if you're used
> to javascript perhaps) tells you this isn't going to get you "derp1" as a
> string, but rather "erp" .. which is exactly what this code wants, but it
> could be done in a less-derpy and less error-prone way (e.g. &"derp"[1]).
>
> I guess I'm saying I'm not a fan of turning off warnings and errors unless
> it's really hopeless upstream.
>
> [ade]
>
This change only turns off turning warnings into fatal errors, doesn't
prevent them from being displayed, and in fact, makes warnings that were
previously *not* reported due to -Wno-* arguments, become visible again.
As a group we have been removing -Werror from builds for a long time.
It would be cool if this was able to be reported (as an error, not a
warning) to the maintainer/committer during testing, a sanity.mk perhaps
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?175048cd-c50a-5f6d-ce21-29aa0cf0d4b6>