From owner-cvs-ports@FreeBSD.ORG Sun Aug 8 21:42:42 2010 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9893D106564A; Sun, 8 Aug 2010 21:42:42 +0000 (UTC) (envelope-from jhein@gossamer.timing.com) Received: from mout.perfora.net (mout.perfora.net [74.208.4.194]) by mx1.freebsd.org (Postfix) with ESMTP id 5CB928FC13; Sun, 8 Aug 2010 21:42:42 +0000 (UTC) Received: from gossamer.timing.com ([206.168.13.144]) by mrelay.perfora.net (node=mrus3) with ESMTP (Nemesis) id 0M5uHB-1OtAwy18Jd-00xg9Z; Sun, 08 Aug 2010 17:42:35 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19551.9408.179087.870716@gossamer.timing.com> Date: Sun, 8 Aug 2010 15:42:24 -0600 From: John Hein To: Remko Lodder In-Reply-To: <2BB5984C-596F-4E81-93F5-A6910D8B85BF@elvandar.org> References: <201008062159.o76LxsbT064236@repoman.freebsd.org> <19550.59049.226541.911898@gossamer.timing.com> <20100808191907.GA26232@FreeBSD.org> <2BB5984C-596F-4E81-93F5-A6910D8B85BF@elvandar.org> X-Provags-ID: V02:K0:DScB7zhIc4U9Fo0yOkYbPf6bSNV1BS7e5diOI6XiQFX MZ72Iw3x9zlmHJppy0CXub4LgTDarW9vtejKV4jzd6Z0UGnFuc g7zkznhkcnS1bcUoyuWZsri1JjPve/Gx1y1cuHAFhWINc4TTKv NOF1vtpw3Ht+bKyrQkdsKeplLXHtd94TIjcZFFwcOzbA090ZdK /lElv0nzz3z6dscxKwibA== Cc: Alexey Dokuchaev , cvs-all@freebsd.org, ports-committers@freebsd.org, Ollivier Robert , Matthias Andree , "portmgr@freebsd.org" , cvs-ports@freebsd.org Subject: Re: cvs commit: ports/devel/mercurial Makefile distinfo pkg-plist X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Aug 2010 21:42:42 -0000 Remko Lodder wrote at 21:21 +0200 on Aug 8, 2010: > > On Aug 8, 2010, at 9:19 PM, Alexey Dokuchaev wrote: > > > On Sun, Aug 08, 2010 at 11:17:29AM -0600, John Hein wrote: > >> Indeed. That is completely my fault. I sent Ollivier the incomplete > >> patch. > > > > The question, however, remains: how could Ollivier possibly commit > > severaly broken submission? Are we guys totally omit testing stuff we > > about to check in these days? :-( > > > > ./danfe > > every 100 commits, one fails, Ollivier does his best, and so are > you and the others, but we all (including you and me) make a > mistake every now and then :) > > I am pretty sure that the next time a patch pops up , Ollivier will > try to do his best + 1, to prevent this from happening. It's the first mistake I've ever made. Seriously, I do try to double check things first, and I could launch into an explanation why the ball was dropped this time. But sometimes it just happens. Sorry it was for a more highly visible port. Please, let's move on with a promise to not let our vigilance guard down - I think this was just a hiccup rather than an indication of ystemic failure.