From owner-svn-src-all@FreeBSD.ORG Thu Apr 2 18:32:22 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9A628636; Thu, 2 Apr 2015 18:32:22 +0000 (UTC) Received: from cyrus.watson.org (cyrus.watson.org [198.74.231.69]) by mx1.freebsd.org (Postfix) with ESMTP id 647ABEBA; Thu, 2 Apr 2015 18:32:22 +0000 (UTC) Received: from [10.0.1.17] (host81-157-243-31.range81-157.btcentralplus.com [81.157.243.31]) by cyrus.watson.org (Postfix) with ESMTPSA id A6BF546B35; Thu, 2 Apr 2015 14:32:20 -0400 (EDT) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: svn commit: r280971 - in head: contrib/ipfilter/tools share/man/man4 sys/contrib/ipfilter/netinet sys/netinet sys/netipsec sys/netpfil/pf From: "Robert N. M. Watson" In-Reply-To: <551D8945.8050906@selasky.org> Date: Thu, 2 Apr 2015 19:32:19 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <8900318B-8155-4131-A0C3-3DE169782EFC@FreeBSD.org> References: <201504012226.t31MQedN044443@svn.freebsd.org> <1427929676.82583.103.camel@freebsd.org> <20150402123522.GC64665@FreeBSD.org> <20150402133751.GA549@dft-labs.eu> <20150402134217.GG64665@FreeBSD.org> <20150402135157.GB549@dft-labs.eu> <1427983109.82583.115.camel@freebsd.org> <20150402142318.GC549@dft-labs.eu> <20150402143420.GI64665@FreeBSD.org> <20150402153805.GD549@dft-labs.eu> <551D8143.4060509@selasky.org> <551D8945.8050906@selasky.org> To: Hans Petter Selasky X-Mailer: Apple Mail (2.2070.6) Cc: Mateusz Guzik , Ian Lepore , svn-src-all@freebsd.org, src-committers@freebsd.org, Gleb Smirnoff , svn-src-head@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Apr 2015 18:32:22 -0000 On 2 Apr 2015, at 19:24, Hans Petter Selasky wrote: > In my sketchup I assume that packets for the same destination will not = be re-ordered. I see that the current ip_reass() code does not care = about TCP or UDP port numbers at all. Maybe we should add code to check = that the packet belongs to the same ports too? Higher-level network headers will appear only in the first fragment, so = can't be used in matching later fragments. > Does somebody here know what happens in these two cases: >=20 > If we are transmitting using TSO, will the network adapter increment = the IP ID field somehow? What happens if an outgoing IP packet resulting = from a TSO packet get fragmented by a router? Quite possibly -- this is presumably specified by the NIC vendor, but it = would be good to do a bit of a survey and see what happens in practice. > In ip_fragment() when we create fragments we should increment the = ip_id value for each fragment? That you are asking this question while hacking on the IP ID code is = deeply troubling. Please go read up on how IP fragmentation works before = going any further with these changes! Robert=