From owner-svn-ports-all@freebsd.org Wed Dec 23 23:14:07 2015 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C7BF5A501B4; Wed, 23 Dec 2015 23:14:07 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 74185187F; Wed, 23 Dec 2015 23:14:07 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by mail-wm0-x230.google.com with SMTP id p187so161274244wmp.0; Wed, 23 Dec 2015 15:14:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=SvMqJwqbkyLdC+Hyhg2UaG5PIIfRnt1mNk597OOATSE=; b=iIhMqFuvsXZVxhuktbdsm96glM/ywwXkZOPlCMLQLsnSduXyoX0xVwjo7Pmc5Do7t/ 0LVpNCAYK7eYPuw9gyXzeLSVBG2laaL5nhcCelAZD5YmwCb7yWbaYM4eUhpoh2PYAj2e qlXQWconmP2/Y6mvtd+doO1q2kbAMPIAppkbMBHlnUPg/r2JtJ0fYVk3lEnsPDuU2byk h3qz+2t9kfBpUWpPdU1sWSSlrqJ4rNIduBXjUW8fjXt2+N6CdB3Qwu2+mS7V8YH9UW6G CLtdOn1RKGvZUQD9OpptsZXKLUoRW+SmdLF+YIjQtnw2FmGYMLx5k8EuNfm2QzkDa78j YDUg== X-Received: by 10.28.138.6 with SMTP id m6mr37078978wmd.82.1450912445836; Wed, 23 Dec 2015 15:14:05 -0800 (PST) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id w23sm18130263wmd.1.2015.12.23.15.14.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Dec 2015 15:14:04 -0800 (PST) Sender: Baptiste Daroussin Date: Thu, 24 Dec 2015 00:14:02 +0100 From: Baptiste Daroussin To: Adam Weinberger Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r404326 - head/shells/zsh Message-ID: <20151223231402.GF20454@ivaldir.etoilebsd.net> References: <201512232256.tBNMukWr007966@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Il7n/DHsA0sMLmDu" Content-Disposition: inline In-Reply-To: <201512232256.tBNMukWr007966@repo.freebsd.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Dec 2015 23:14:08 -0000 --Il7n/DHsA0sMLmDu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 23, 2015 at 10:56:46PM +0000, Adam Weinberger wrote: > Author: adamw > Date: Wed Dec 23 22:56:46 2015 > New Revision: 404326 > URL: https://svnweb.freebsd.org/changeset/ports/404326 >=20 > Log: > Partially revert r403755. It can't build the curses module against ncur= ses from > ports. It probably can, but configure is too smart to figure that out. > =20 > I have no confidence that linking against curses from ports results in = a properly > working zshell. So, for now, back out the change. It will build a share= d lib zsh > against ncurses from ports, but breaks statically-linked zsh's. Mark th= e port > as IGNORE if we're using ncurses from ports and building a static zsh. > =20 > Also, remove a regression-test target that isn't useful anymore (thanks= to bapt > for the reminder about this). > =20 > I am not enthused about this change. It doesn't really "fix" the below = PR, so > much as shoot ourselves in the other foot instead. > =20 > PR: 205500 >=20 The solution is to make --with-term-lib=3D"tinfow tinfo" only when building= static because when building static you will never build the curses module something like --with-term-lib=3D"${TERMLIB}" TERMLIB=3D"ncursesw ncurses" then later: =2Eif ${PORT_OPTIONS:MSTATIC} TERMLIB=3D"tinfow tinfo" =2Eendif Which will also fix static building with base the day we split libtinfo* fr= om libncurses, which would be nice to do in base :) Best regards, Bapt --Il7n/DHsA0sMLmDu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWeyq6AAoJEGOJi9zxtz5aqe4QALdHJiOUQ0QwcH+Y6NCCz+Bf ltc6/tBWkj4a1gUEpx5SEAHEWuF2hLsHP2s/fgiC/+E1vTntut+c2SzaB1a32wy0 phqO+AjNiGwCBLmBL5jn+XoqkQ3Ir0RPe7VdQOWUMbsRDXsFIZ6BCER9Tv+P5y4C bpzPfvPKf1R75Xo4khl6ZNit6v8N/FktgfYXvHHgqGxv3237U5ee07hPNsWG8CPc 4AvUhcKbjBxGi5B9KjUM/CVqRcIrqucEiqpjmbN8Gi4poNljog+hC8IoNtLJgZwB B9QiVf/NtcPawNbeUbjyAxsqFRjjR31AgR59BegDJcTKqnlvNPlJw4+xPYE0yMz5 0HiZrtGJcJHX5Qs7722jDp51Q/dAC9YiBwkK7D1e56CeA6HKY5Z3mJmrFWtVVLMR JM0sLYtFbusPVL9fFyKDnrfckEeNZ6Q+jGLY3vxGfrPjCBRH+JxceHcOlBOPiD6c FA4ZGXL6R4kfZxEo6AAKZeMS2MvT29PrWTSwrSvvfrOPSun+dELtMYNGaXXJLNN8 nUqQh4UhRWGerQGBA6f0Lrw6wDmsy1/0imAV7ByrLYPvFL6KMKXqZyq4fkpqmmQF rYIaoGj2FR+tJzBfKqRD1D2jbg3TZegRjiIwH51oD/KmIOqTqeEz0KYM+NiTqL5x buo1K4+rCtUtA8g92nEq =9IEN -----END PGP SIGNATURE----- --Il7n/DHsA0sMLmDu--