From nobody Tue Mar 3 12:22:42 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fQFLl6xfsz6T3TY for ; Tue, 03 Mar 2026 12:22:55 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fQFLl51HBz3cpY for ; Tue, 03 Mar 2026 12:22:55 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pj1-x102d.google.com with SMTP id 98e67ed59e1d1-3598b2318c2so1232452a91.3 for ; Tue, 03 Mar 2026 04:22:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1772540574; cv=none; d=google.com; s=arc-20240605; b=kGBUZJM9DkehlDFWPG6BzPVZzS9gW8/xMoJq6f/DJXNFqgTYjKC+a7YhRWmTbJaP5T 3YzM6+QlTenFWwVyrYJ8oLdfQqYnUBKnh0Qab7H9cUqnDJl0gX5Rqh91c5gURMsB+7Jn YV143C7zFin3IE0uNDkQj4WvTc6XfajtgesuXATZQwIy6AEV01i78HehKleUXbrEBO8n Sz6TwWXNE763qGozaoIu1K1n1LUGsbBl2T1PqNlcRZHtO5lXC+rR/W+CCk9lP79i0i8x xqpgqig/sD3MrZQkKLUUsIwxV0ooAQuN+yrzNp4UFm3rlj/rmwP1nLrGrF0LnkZM9EXe Kezw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=bdE7lbu1GQ/XGD9KX4lBzwzb8cI5hK67bQEE5T2fKU0=; fh=oDmUv+gOGP/cuUYRwPbMBo76G2znjUU3u495iyD4cXo=; b=f9LECKffaZvhPqVKqOxNdJyCUoJ/4BNCBnbmB2BV233Gq5IJQyTF+Hotn3dFkXtGjY 3aIwf+f8jYXuBA4m+VE3SA+LJEwaEnEwH3iVF5zh2Ry69M3dziRhv6cUHhgy9+QRKalH Mq4nGtKRHdc9jq9A8P4ryWh8Wnl6EGgw9DUNgdB72gRNKKqtN9MDQVsv7yJd0ubLnmrx /k/VyWMslWsJUQg0I0TgUr8eXg4G0HufCodlholvhhyKjq/oMMc47TfcFOmxygudNyk1 UJDud45vOPXbgXwHfdG0jrXuOfbpO4Wrkf0XS0iORhXfYjo/fsjXyBhj1iyGV3teAMTD M90w==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1772540574; x=1773145374; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bdE7lbu1GQ/XGD9KX4lBzwzb8cI5hK67bQEE5T2fKU0=; b=YfCSwlHDT03/bkpA85zPyom0lvjOPd1B9HcZw2GUzBGAN6cgOE/FtWc/XBTYa+MlNQ LBufP3OAGKx2la8afuimMaD3g+h+2S0GNKww1yku5bzQKfDQGIc/uOPcSAjZ2P+4++pH +ujytGWm9CVvY/NyAAprq1GwDiVxD0XUCM59nNbSJ4HjnkyCoj62rfq61jlkAPUEJ33p 4nocZ12+FYjVJ3jgFHPOla1rNTT/BU/qMqU9PbHmmJnm/l7nYx1pq29aeNM59IZipNgK OIwIknuMEigKIl4MAJWnL4OTAo1WPQryNHp6xm+u6l0hjszJElz3AQK1f6OyEsfpHZYe 61RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772540574; x=1773145374; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bdE7lbu1GQ/XGD9KX4lBzwzb8cI5hK67bQEE5T2fKU0=; b=FJDURMI9M5QICUBuiIDh895dQiHKSpN3BmAfDROmRFx4ik1l1MfNaD1Y2QIkmfoC4b WliHPOHewp0JiAj7Eib8dwL+sxlagaT41fW64zydyTevhDA2CC3zESbM0WDEaRXlydSV 4fyD/4vFZXfvtRg5yK7z35k44nmiaZWpquAyxgzTiLl2hFsfn2sHMgI19lUFc9/cDwUX 9nnZO3Zd6YGReMHkK3cghTXLuyJEhIzWkd/xLS7vs32HqLCBCWD6DyWvBIIvW4gouhst BcyTsJ9RL461Re398W/bYZQyQ+dDR6UM0gnv+xW/IbDAcouWVUMi57UsgsgfG8kBC+me 0YoQ== X-Forwarded-Encrypted: i=1; AJvYcCXik7GkmKj81zxmg447a/Sf/Fk7D+rK0cTnjGky+FrHX+MHMnVnHZJ/N46RUdU3U+I/NaDg8VMoFmfKWAtQOj7C+6GuGA==@freebsd.org X-Gm-Message-State: AOJu0YwNeXCaZOTPSxnVPYkdDsENxcYYcRYP57nR2CYD1HE4Af1gOHKO nb0BK735HirObKUJPkVYQzzpXt8vLRo4aOXe7+ODrE248p43Y76Hwlf+TkBiSOvcPBehfw8dRYk S/QybaNgkS0rjJLJcFI1jh5Kd4KcwX/qWqgeVSpzT4Q== X-Gm-Gg: ATEYQzxHDZclc6FmbITZcdRzy4ye6oHSyoBM50PS1N1Xj4RAY4P3VSHAe36wXiNEERs OelHG6+vBmBLgS/Xh4W4APy0iPemmsWVRTJ09udsi7Xl+d+9wgxSRy/S4v6QosjS9tXP9mnJN1Q /AdXwjavy6wC9Fd7VPN6dyy8m9a6ezitiQh4WqlAefHqN0Gh+2xPMTWQc+JagliPpP5I3VGXLjI z6WSLbyaX4zP23NdiBamchyrgGVyGeONhoePTHo4WHTLI4U7Udg6Ye1qtj6cf5AeWWrUZV9EFbk frWKzkQ= X-Received: by 2002:a17:90b:2e0e:b0:359:8d38:cdee with SMTP id 98e67ed59e1d1-3598d38dcbdmr5672727a91.2.1772540573608; Tue, 03 Mar 2026 04:22:53 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <69a678f3.3f811.148b0d7d@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Tue, 3 Mar 2026 05:22:42 -0700 X-Gm-Features: AaiRm51-d9MmHTvMClVX0KURzOo75eC0I0uaLzl9aojDlLQ-OuEnr3lWSxZtq60 Message-ID: Subject: Re: git: 912864912b71 - main - Run `make obj` before running `make test-includes` To: Brooks Davis Cc: Enji Cooper , src-committers , "" , "" Content-Type: multipart/alternative; boundary="0000000000003d7be1064c1dc36c" X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4fQFLl51HBz3cpY X-Spamd-Bar: ---- --0000000000003d7be1064c1dc36c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Mar 3, 2026 at 5:18=E2=80=AFAM Brooks Davis wr= ote: > On Tue, Mar 03, 2026 at 04:25:48AM -0700, Warner Losh wrote: > > On Mon, Mar 2, 2026, 11:00???PM Enji Cooper wrote: > > > > > The branch main has been updated by ngie: > > > > > > URL: > > > > https://cgit.FreeBSD.org/src/commit/?id=3D912864912b71951f9a636190b1dba80= 528f588eb > > > > > > commit 912864912b71951f9a636190b1dba80528f588eb > > > Author: Enji Cooper > > > AuthorDate: 2026-03-03 05:59:50 +0000 > > > Commit: Enji Cooper > > > CommitDate: 2026-03-03 05:59:56 +0000 > > > > > > Run `make obj` before running `make test-includes` > > > > > > Before this change, `make test-includes` (run as part of > buildworld) > > > would place test files in the current directory, which would > clutter up > > > git clones. Run `make obj` beforehand to ensure that the files ar= e > put > > > in `${.OBJDIR}` instead of `${.CURDIR}`. This helps cut down on t= he > > > noise significantly when running commands like `git status`. > > > > > > > I've never seen this happen. .OBJDIR is created automatically for me > always > > for the last 5 years... I run buildworld all the time. Can you explain > when > > / how it happens more specifically or back out the change? > > The commit message is unintentionally misleading and incomplete. I hit > the problem a week or so ago when fixing gcc12 builds and lacked the > time to follow up. test-includes is fine as part of buildworld, but > when run directly from src does fill tools/build/test-includes with .c > files if you blow away the objdir (which seems to the the only reliably > way to cause test-includes to retest some more complex cases.) > Ah! That should have been in the commit message as the edge case that provoked this. That's a decent explanation, though there's other bits of buildworld that will also cause problems if you do them in isolatio= n and not part of buildworld. This one, though, is important enough to make an exception for, I think. It's one that's most likely to be used in isolation. Warner --0000000000003d7be1064c1dc36c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Mar 3, = 2026 at 5:18=E2=80=AFAM Brooks Davis <brooks@freebsd.org> wrote:
On Tue, Mar 03, 2026 at 04:25:48AM -0700, Warner Losh= wrote:
> On Mon, Mar 2, 2026, 11:00???PM Enji Cooper <ngie@freebsd.org> wrote:
>
> > The branch main has been updated by ngie:
> >
> > URL:
> > https://= cgit.FreeBSD.org/src/commit/?id=3D912864912b71951f9a636190b1dba80528f588eb<= /a>
> >
> > commit 912864912b71951f9a636190b1dba80528f588eb
> > Author:=C2=A0 =C2=A0 =C2=A0Enji Cooper <ngie@FreeBSD.org> > > AuthorDate: 2026-03-03 05:59:50 +0000
> > Commit:=C2=A0 =C2=A0 =C2=A0Enji Cooper <ngie@FreeBSD.org> > > CommitDate: 2026-03-03 05:59:56 +0000
> >
> >=C2=A0 =C2=A0 =C2=A0Run `make obj` before running `make test-inclu= des`
> >
> >=C2=A0 =C2=A0 =C2=A0Before this change, `make test-includes` (run = as part of buildworld)
> >=C2=A0 =C2=A0 =C2=A0would place test files in the current director= y, which would clutter up
> >=C2=A0 =C2=A0 =C2=A0git clones. Run `make obj` beforehand to ensur= e that the files are put
> >=C2=A0 =C2=A0 =C2=A0in `${.OBJDIR}` instead of `${.CURDIR}`. This = helps cut down on the
> >=C2=A0 =C2=A0 =C2=A0noise significantly when running commands like= `git status`.
> >
>
> I've never seen this happen. .OBJDIR is created automatically for = me always
> for the last 5 years... I run buildworld all the time. Can you explain= when
> /=C2=A0 how it happens more specifically or back out the change?

The commit message is unintentionally misleading and incomplete.=C2=A0 I hi= t
the problem a week or so ago when fixing gcc12 builds and lacked the
time to follow up.=C2=A0 test-includes is fine as part of buildworld, but when run directly from src does fill tools/build/test-includes with .c
files if you blow away the objdir (which seems to the the only reliably
way to cause test-includes to retest some more complex cases.)

Ah! That should have been in the commit message as = the edge case
that provoked this. That's a decent explanation= , though there's other
bits of buildworld that will also caus= e problems if you do them in isolation
and not part of buildworld= . This one, though, is important enough to make
an exception for,= I think. It's one that's most likely to be used in isolation.

Warner=C2=A0
--0000000000003d7be1064c1dc36c--