Date: Mon, 26 Dec 2011 14:51:36 -0800 From: Steve Kargl <sgk@troutmask.apl.washington.edu> To: Doug Barton <dougb@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Marius Strobl <marius@alchemy.franken.de> Subject: Re: svn commit: r228857 - in head/usr.bin: . csup Message-ID: <20111226225136.GA79882@troutmask.apl.washington.edu> In-Reply-To: <4EF8DC5B.9070404@FreeBSD.org> References: <201112241216.pBOCGd1H012696@svn.freebsd.org> <4EF645D2.8080407@FreeBSD.org> <20111226102820.GT90831@alchemy.franken.de> <4EF8DC5B.9070404@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Dec 26, 2011 at 12:43:07PM -0800, Doug Barton wrote: > On 12/26/2011 02:28, Marius Strobl wrote: > > On Sat, Dec 24, 2011 at 01:36:18PM -0800, Doug Barton wrote: > >> On 12/24/2011 04:16, Marius Strobl wrote: > >>> On FreeBSD just use the MD5 implementation of libmd rather than that of > >>> libcrypto so we don't need to relinquish csup when world is built without > >>> OpenSSL. > >> > >> Did you benchmark this at all? I agree that keeping csup available > >> absent openssl is a good goal, but csup is a prototypical "tool that > >> does the same thing many thousands of times" so even tiny regressions > >> could add up to a large cost in wall clock time. > > > > Well, in a real world test updating the same base on an amd64 machine > > connected to the Internet > > Adding a network connection to the test is almost certainly going to > obscure the results beyond utility. Given that the majority of FreeBSD users will be pulling code from the internet, this seems to be the most relevant test. > The appropriate way to test this > would be to create a binary out of the md5 routine in csup, and link it > alternately with libcrypto and libmd. Then for each version run it > against the src tree (or ports, either way) 10 times. Discard the first > and last, and then plot the results with ministat. The proper way to test the libmd vs libcrypto versions of the md5 routines is to use a profiler. Of course, one might ask the question on how the use of libmd effects the majority of FreeBSD users (ie., not FreeBSD developers). Does the majority run csup hourly? Daily? Weekly? For a utility seldomly run be the majority of FreeBSD users, Doug, you seem to be wasting Marius's time. -- Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111226225136.GA79882>