From owner-freebsd-current@FreeBSD.ORG  Tue Jun 23 17:26:52 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@FreeBSD.org
Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by hub.freebsd.org (Postfix) with ESMTP id 941771065670;
	Tue, 23 Jun 2009 17:26:51 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
From: Jung-uk Kim <jkim@FreeBSD.org>
To: freebsd-current@FreeBSD.org
Date: Tue, 23 Jun 2009 13:26:39 -0400
User-Agent: KMail/1.6.2
References: <20090621082022.GA88526@freebsd.org>
In-Reply-To: <20090621082022.GA88526@freebsd.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200906231326.42555.jkim@FreeBSD.org>
Cc: Roman Divacky <rdivacky@freebsd.org>
Subject: Re: [PATCH]: if (cond); foo() in firewire
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Jun 2009 17:26:52 -0000

On Sunday 21 June 2009 04:20 am, Roman Divacky wrote:
> hi
>
> is this patch correct? may I commit it?
>
> Index: ../../../dev/firewire/fwdev.c
> ===================================================================
> --- ../../../dev/firewire/fwdev.c       (revision 194573)
> +++ ../../../dev/firewire/fwdev.c       (working copy)
> @@ -443,7 +443,7 @@
>         xfer->send.pay_len = uio->uio_resid;
>         if (uio->uio_resid > 0) {
>                 if ((err = uiomove((caddr_t)&xfer->send.payload[0],
> -                   uio->uio_resid, uio)));
> +                   uio->uio_resid, uio)))
>                         goto out;
>         }
>
>
> another bug found by the "useless warnings in clang" ;)

Just for the record, it seems this bug was fixed in NetBSD long ago:

http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/dev/ieee1394/fwdev.c.diff?r1=1.3&r2=1.4

I hope it boosts your confidence level a bit. :-)

Jung-uk Kim