From owner-freebsd-geom@FreeBSD.ORG Sun Sep 5 15:50:07 2010 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1D3491065693 for ; Sun, 5 Sep 2010 15:50:07 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E646E8FC19 for ; Sun, 5 Sep 2010 15:50:06 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o85Fo6Gv075236 for ; Sun, 5 Sep 2010 15:50:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o85Fo65n075234; Sun, 5 Sep 2010 15:50:06 GMT (envelope-from gnats) Date: Sun, 5 Sep 2010 15:50:06 GMT Message-Id: <201009051550.o85Fo65n075234@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: Alexander Best Cc: Subject: Re: bin/150239: gpart bootcode displays highly ambiguous message X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Alexander Best List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Sep 2010 15:50:07 -0000 The following reply was made to PR bin/150239; it has been noted by GNATS. From: Alexander Best To: bug-followup@freebsd.org Cc: Subject: Re: bin/150239: gpart bootcode displays highly ambiguous message Date: Sun, 5 Sep 2010 15:42:33 +0000 --lrZ03NoBR/3+SXJZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline this patch changes the output like you suggested. also my editor discovered an unnecessary space in g_part.c ;) cheers. alex -- a13x --lrZ03NoBR/3+SXJZ Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="g_part.c.diff" diff --git a/sys/geom/part/g_part.c b/sys/geom/part/g_part.c index b9fca08..5efe7ef 100644 --- a/sys/geom/part/g_part.c +++ b/sys/geom/part/g_part.c @@ -571,7 +571,7 @@ g_part_ctl_bootcode(struct gctl_req *req, struct g_part_parms *gpp) /* Provide feedback if so requested. */ if (gpp->gpp_parms & G_PART_PARM_OUTPUT) { sb = sbuf_new_auto(); - sbuf_printf(sb, "%s has bootcode\n", gp->name); + sbuf_printf(sb, "bootcode was written to %s\n", gp->name); sbuf_finish(sb); gctl_set_param(req, "output", sbuf_data(sb), sbuf_len(sb) + 1); sbuf_delete(sb); @@ -967,7 +967,7 @@ g_part_ctl_move(struct gctl_req *req, struct g_part_parms *gpp) { gctl_error(req, "%d verb 'move'", ENOSYS); return (ENOSYS); -} +} static int g_part_ctl_recover(struct gctl_req *req, struct g_part_parms *gpp) --lrZ03NoBR/3+SXJZ--