Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 27 Oct 2012 12:58:52 +0200
From:      Andre Oppermann <andre@freebsd.org>
To:        Gleb Smirnoff <glebius@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r242161 - in head/sys: net netinet netpfil/pf
Message-ID:  <508BBE6C.7010409@freebsd.org>
In-Reply-To: <201210262106.q9QL6YgY000943@svn.freebsd.org>
References:  <201210262106.q9QL6YgY000943@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 26.10.2012 23:06, Gleb Smirnoff wrote:
> Author: glebius
> Date: Fri Oct 26 21:06:33 2012
> New Revision: 242161
> URL: http://svn.freebsd.org/changeset/base/242161
>
> Log:
>    o Remove last argument to ip_fragment(), and obtain all needed information
>      on checksums directly from mbuf flags. This simplifies code.
>    o Clear CSUM_IP from the mbuf in ip_fragment() if we did checksums in
>      hardware. Some driver may not announce CSUM_IP in theur if_hwassist,
>      although try to do checksums if CSUM_IP set on mbuf. Example is em(4).

I'm not getting your description here?  Why work around a bug in a driver
in ip_fragment() when we can fix the bug in the driver?

>    o While here, consistently use CSUM_IP instead of its alias CSUM_DELAY_IP.
>      After this change CSUM_DELAY_IP vanishes from the stack.

Good. :)

>    Submitted by:	Sebastian Kuzminsky <seb lineratesystems.com>

-- 
Andre




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?508BBE6C.7010409>