From owner-svn-src-head@FreeBSD.ORG  Sat Oct 27 10:59:08 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id C95B0589
 for <svn-src-head@freebsd.org>; Sat, 27 Oct 2012 10:59:08 +0000 (UTC)
 (envelope-from andre@freebsd.org)
Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2])
 by mx1.freebsd.org (Postfix) with ESMTP id 2B68D8FC16
 for <svn-src-head@freebsd.org>; Sat, 27 Oct 2012 10:59:07 +0000 (UTC)
Received: (qmail 71583 invoked from network); 27 Oct 2012 12:36:25 -0000
Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2])
 (envelope-sender <andre@freebsd.org>)
 by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP
 for <glebius@FreeBSD.org>; 27 Oct 2012 12:36:25 -0000
Message-ID: <508BBE6C.7010409@freebsd.org>
Date: Sat, 27 Oct 2012 12:58:52 +0200
From: Andre Oppermann <andre@freebsd.org>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:16.0) Gecko/20121010 Thunderbird/16.0.1
MIME-Version: 1.0
To: Gleb Smirnoff <glebius@FreeBSD.org>
Subject: Re: svn commit: r242161 - in head/sys: net netinet netpfil/pf
References: <201210262106.q9QL6YgY000943@svn.freebsd.org>
In-Reply-To: <201210262106.q9QL6YgY000943@svn.freebsd.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Oct 2012 10:59:08 -0000

On 26.10.2012 23:06, Gleb Smirnoff wrote:
> Author: glebius
> Date: Fri Oct 26 21:06:33 2012
> New Revision: 242161
> URL: http://svn.freebsd.org/changeset/base/242161
>
> Log:
>    o Remove last argument to ip_fragment(), and obtain all needed information
>      on checksums directly from mbuf flags. This simplifies code.
>    o Clear CSUM_IP from the mbuf in ip_fragment() if we did checksums in
>      hardware. Some driver may not announce CSUM_IP in theur if_hwassist,
>      although try to do checksums if CSUM_IP set on mbuf. Example is em(4).

I'm not getting your description here?  Why work around a bug in a driver
in ip_fragment() when we can fix the bug in the driver?

>    o While here, consistently use CSUM_IP instead of its alias CSUM_DELAY_IP.
>      After this change CSUM_DELAY_IP vanishes from the stack.

Good. :)

>    Submitted by:	Sebastian Kuzminsky <seb lineratesystems.com>

-- 
Andre