Date: Wed, 24 Mar 2010 06:40:07 GMT From: Kai Kockro <kkockro@web.de> To: freebsd-fs@FreeBSD.org Subject: Re: kern/144330: [nfs] mbuf leakage in nfsd with zfs Message-ID: <201003240640.o2O6e7YG007546@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/144330; it has been noted by GNATS. From: Kai Kockro <kkockro@web.de> To: Rick Macklem <rmacklem@uoguelph.ca> Cc: Daniel Braniss <danny@cs.huji.ac.il>, Mikolaj Golub <to.my.trociny@gmail.com>, Jeremy Chadwick <freebsd@jdc.parodius.com>, freebsd-fs@freebsd.org, bug-followup@freebsd.org, gerrit@pmp.uni-hannover.de Subject: Re: kern/144330: [nfs] mbuf leakage in nfsd with zfs Date: Wed, 24 Mar 2010 07:39:04 +0100 Hi, after 3 days with the first patch ( FreeBSD 8-STABLE AMD64, old nfsd ): netstat -m 5732/10528/16260 mbufs in use (current/cache/total) 4825/10131/14956/262144 mbuf clusters in use (current/cache/total/max) It looks very fine. I'll patch with the final corrections and then test aga= in. But why i have the same issues? I dont use UDP connects, only TCP?! Greetings, Kai Am Dienstag, 23. M=E4rz 2010 14:34:39 schrieb Rick Macklem: > On Tue, 23 Mar 2010, Daniel Braniss wrote: > >> I only have a FreeBSD client at this point, and it doesn't cause the > >> leak for nfsv3,udp for me here. > > > > my client is also FreeBSD 8.0, strange >=20 > I was already using the patch below when I tested and couldn't see it, > so I guess it now appears that the patch works. >=20 > >> Doug Rabson pointed out that there would be a leak for the "default:" > >> case too, although didn't know if that would occur in practice. > > > > it does! :-) > > > >> So, maybe you could test this variant of the patch (just in case that > >> was the slow leak...): > >> --- rpc/svc.c.sav 2010-03-21 18:46:20.000000000 -0400 > >> +++ rpc/svc.c 2010-03-22 19:00:17.000000000 -0400 > >> @@ -819,9 +819,11 @@ > >> free(r->rq_addr, M_SONAME); > >> r->rq_addr =3D NULL; > >> } > >> + m_freem(args); > >> goto call_done; > >> > >> default: > >> + m_freem(args); > >> goto call_done; > >> } > >> } > > > > that plugged it! > > see > > ftp://ftp.cs.huji.ac.il/users/danny/freebsd/mbuf-leak/store-02+++.ps >=20 > Good work with the testing. I'll get it committed and put it up on the > nfs patches page I have under http://people.freebsd.org/~rmacklem >=20 > > thanks to you for taking time off of your retirement :-) >=20 > I plan on doing quite a bit of FreeBSD/NFS stuff during it, rick >=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201003240640.o2O6e7YG007546>