From owner-freebsd-current@FreeBSD.ORG Fri May 7 18:24:01 2004 Return-Path: Delivered-To: freebsd-current@www.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C2EE616A4CE for ; Fri, 7 May 2004 18:24:01 -0700 (PDT) Received: from arginine.spc.org (arginine.spc.org [195.206.69.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0930043D4C for ; Fri, 7 May 2004 18:24:01 -0700 (PDT) (envelope-from bms@spc.org) Received: from localhost (localhost [127.0.0.1]) by arginine.spc.org (Postfix) with ESMTP id 36F156538E; Sat, 8 May 2004 02:23:59 +0100 (BST) Received: from arginine.spc.org ([127.0.0.1]) by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 46126-04; Sat, 8 May 2004 02:23:58 +0100 (BST) Received: from empiric.dek.spc.org (82-147-17-88.dsl.uk.rapidplay.com [82.147.17.88]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by arginine.spc.org (Postfix) with ESMTP id 3C72665371; Sat, 8 May 2004 02:23:58 +0100 (BST) Received: by empiric.dek.spc.org (Postfix, from userid 1001) id 7E62E60EE; Sat, 8 May 2004 02:23:57 +0100 (BST) Date: Sat, 8 May 2004 02:23:57 +0100 From: Bruce M Simpson To: Tim Robbins Message-ID: <20040508012357.GA37547@empiric.dek.spc.org> References: <20040507092235.GA61837@stack.nl> <20040507100119.GA15782@cat.robbins.dropbear.id.au> <20040507235556.GB37035@empiric.dek.spc.org> <20040508010228.GA18935@cat.robbins.dropbear.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040508010228.GA18935@cat.robbins.dropbear.id.au> cc: Marc Olzheim cc: Poul-Henning Kamp cc: freebsd-current@www.freebsd.org Subject: Re: Unified getcwd() implementation X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 May 2004 01:24:01 -0000 On Sat, May 08, 2004 at 11:02:28AM +1000, Tim Robbins wrote: > It's not inherently Linux-specific, but it exists solely for the benefit > of Linux emulation. I don't see why they need to be merged at the > expense of complicating the native system calls -- we have way > too many tentacles of the Linux emulator reaching in there already. Sorry, what you are saying here doesn't seem to make sense to me. The implementation of getcwd() in the Linux emulator is a full getcwd() implementation. The whole point of reverting to directory scanning rather than using the namecache is to address the problems caused when path components can't be found in the namecache; this is the ethos of the patch, which eliminates the duplicated functionality in the Linuxulator at the same time. I don't understand how this 'complicates native system calls' when it's intended to address several PRs which exist with regards to our current implementation of getcwd() in FreeBSD, unless there is something I'm missing? > > You seem to be concerned about plagiarism. Could you clarify or explain > > your concerns? > > getcwd_scandir() has clearly been copied from linux_getcwd.c. The work > needs to be attributed to the author, Bill Sommerfeld, and the NetBSD > license needs to be honoured. Fair point well made. The patch was a 'quick hack' and wasn't intended to be committed when it was written precisely because of this. Regards, BMS