From owner-cvs-all  Sat Nov 16 19:33:19 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id A9BDB37B401; Sat, 16 Nov 2002 19:33:18 -0800 (PST)
Received: from khavrinen.lcs.mit.edu (khavrinen.lcs.mit.edu [18.24.4.193])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 0FD2243E42; Sat, 16 Nov 2002 19:33:18 -0800 (PST)
	(envelope-from wollman@khavrinen.lcs.mit.edu)
Received: from khavrinen.lcs.mit.edu (localhost [IPv6:::1])
	by khavrinen.lcs.mit.edu (8.12.3/8.12.5) with ESMTP id gAH3XHen099555
	(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK);
	Sat, 16 Nov 2002 22:33:17 -0500 (EST)
	(envelope-from wollman@khavrinen.lcs.mit.edu)
Received: (from wollman@localhost)
	by khavrinen.lcs.mit.edu (8.12.3/8.12.5/Submit) id gAH3XG7o099552;
	Sat, 16 Nov 2002 22:33:16 -0500 (EST)
	(envelope-from wollman)
Date: Sat, 16 Nov 2002 22:33:16 -0500 (EST)
From: Garrett Wollman <wollman@lcs.mit.edu>
Message-Id: <200211170333.gAH3XG7o099552@khavrinen.lcs.mit.edu>
To: Alfred Perlstein <alfred@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libc/gen sysconf.c
In-Reply-To: <20021117030805.GA6882@elvis.mu.org>
References: <200211160635.gAG6ZKUX094649@repoman.freebsd.org>
	<200211160706.gAG76Z4S089556@khavrinen.lcs.mit.edu>
	<20021116095822.GT50692@elvis.mu.org>
	<200211170202.gAH22oLd099179@khavrinen.lcs.mit.edu>
	<20021117030805.GA6882@elvis.mu.org>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

<<On Sat, 16 Nov 2002 19:08:05 -0800, Alfred Perlstein <alfred@FreeBSD.org> said:

> In re 1.18, the problem is that the code changes a 0 return to -1,
> at least for _SC_AIO_PRIO_DELTA_MAX, so that portion of the revision
> should stay right?  (since 0 is a valid response from the kernel)

The bug here is that these cases are going through the `yesno' logic
but are not booleans.  Replace the `goto yesno' with `break' and the
Right Thing should happen (i.e., the value from the kernel will be
returned).

-GAWollman


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message