From owner-freebsd-current@FreeBSD.ORG Sun Feb 24 10:46:47 2008 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E4E9B16A403 for ; Sun, 24 Feb 2008 10:46:47 +0000 (UTC) (envelope-from kris@FreeBSD.org) Received: from weak.local (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 0EAC513C457; Sun, 24 Feb 2008 10:46:42 +0000 (UTC) (envelope-from kris@FreeBSD.org) Message-ID: <47C14B0F.8050403@FreeBSD.org> Date: Sun, 24 Feb 2008 11:46:39 +0100 From: Kris Kennaway User-Agent: Thunderbird 2.0.0.9 (Macintosh/20071031) MIME-Version: 1.0 To: Barney Cordoba References: <274346.34322.qm@web63914.mail.re1.yahoo.com> In-Reply-To: <274346.34322.qm@web63914.mail.re1.yahoo.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: current@freebsd.org Subject: Re: splimp() X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Feb 2008 10:46:48 -0000 Barney Cordoba wrote: > I'm porting some older software to 7.0 and I see that > many of the 7.0 drivers use both locks and splimps() > to protect code, particularly the firewire driver. > What cases would an splimp() be required? spl*() are NOPs that are only left behind in some code as a reminder of what mutual exclusion protections used to apply, mostly in cases where there has not been fine-grained locking applied to the code in question. In some (most?) cases they serve no useful annotation purpose and should just be removed. For newly written code they should be added. Kris