From owner-cvs-src@FreeBSD.ORG  Wed Jan 17 19:15:14 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@freebsd.org
Delivered-To: cvs-src@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 436EA16A47C
	for <cvs-src@freebsd.org>; Wed, 17 Jan 2007 19:15:14 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from outA.internet-mail-service.net (outA.internet-mail-service.net
	[216.240.47.224])
	by mx1.freebsd.org (Postfix) with ESMTP id 214A013C461
	for <cvs-src@freebsd.org>; Wed, 17 Jan 2007 19:15:14 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from shell.idiom.com (HELO idiom.com) (216.240.47.20)
	by out.internet-mail-service.net (qpsmtpd/0.32) with ESMTP;
	Wed, 17 Jan 2007 10:55:33 -0800
Received: from [10.251.23.190] (nat.ironport.com [63.251.108.100])
	by idiom.com (Postfix) with ESMTP id 10C1D125B2D;
	Wed, 17 Jan 2007 11:15:10 -0800 (PST)
Message-ID: <45AE75BD.8060703@elischer.org>
Date: Wed, 17 Jan 2007 11:15:09 -0800
From: Julian Elischer <julian@elischer.org>
User-Agent: Thunderbird 1.5.0.9 (Macintosh/20061207)
MIME-Version: 1.0
To: John Baldwin <jhb@freebsd.org>
References: <200701171505.l0HF5qGd068469@repoman.freebsd.org>
	<200701171105.36393.jhb@freebsd.org>
In-Reply-To: <200701171105.36393.jhb@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-src@freebsd.org, src-committers@freebsd.org,
	Xin LI <delphij@freebsd.org>, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/ddb db_command.c db_thread.c src/sys/vm
 vm_object.c
 vm_pageout.c src/sys/i386/i386 pmap.c src/sys/i386/ibcs2 ibcs2_sysvec.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Jan 2007 19:15:14 -0000

John Baldwin wrote:
> On Wednesday 17 January 2007 10:05, Xin LI wrote:
>> delphij     2007-01-17 15:05:52 UTC
>>
>>   FreeBSD src repository
>>
>>   Modified files:
>>     sys/ddb              db_command.c db_thread.c 
>>     sys/vm               vm_object.c vm_pageout.c 
>>     sys/i386/i386        pmap.c 
>>     sys/i386/ibcs2       ibcs2_sysvec.c 
>>   Log:
>>   Use FOREACH_PROC_IN_SYSTEM instead of using its unrolled form.
> 
> I actually think this macro is actually not that useful and I'd rather
> we get rid of it. :)  For one thing zombies are still processes and this
> doesn't cover those, so the name is a bit misleading.  However, this is a 
> minor thing, and I can see that the kernel should be consistent one way or 
> another.  I'd just vote for being consistent by removing FOREACH_PROC and 
> FOREACH_THREAD.  The kernel doesn't use wrappers for other lists, it just 
> uses LIST_FOREACH and TAILQ_FOREACH directly.
> 

I personally prefer to use them and one reason to do so is to allow
the macros to be changed to check locking etc.