From owner-freebsd-ports@freebsd.org  Fri Sep 11 16:50:07 2015
Return-Path: <owner-freebsd-ports@freebsd.org>
Delivered-To: freebsd-ports@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id F1B10A014C6
 for <freebsd-ports@mailman.ysv.freebsd.org>;
 Fri, 11 Sep 2015 16:50:07 +0000 (UTC)
 (envelope-from marquis@roble.com)
Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org
 [IPv6:2001:1900:2254:206a::50:5])
 by mx1.freebsd.org (Postfix) with ESMTP id DF9851BE4
 for <freebsd-ports@freebsd.org>; Fri, 11 Sep 2015 16:50:07 +0000 (UTC)
 (envelope-from marquis@roble.com)
Received: by mailman.ysv.freebsd.org (Postfix)
 id DE853A014C3; Fri, 11 Sep 2015 16:50:07 +0000 (UTC)
Delivered-To: ports@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id DE1C8A014C2
 for <ports@mailman.ysv.freebsd.org>; Fri, 11 Sep 2015 16:50:07 +0000 (UTC)
 (envelope-from marquis@roble.com)
Received: from mx5.roble.com (mx5.roble.com [206.40.34.5])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "mx5.roble.com", Issuer "mx5.roble.com" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id D28861BE3
 for <ports@freebsd.org>; Fri, 11 Sep 2015 16:50:07 +0000 (UTC)
 (envelope-from marquis@roble.com)
Date: Fri, 11 Sep 2015 09:46:31 -0700 (PDT)
From: Roger Marquis <marquis@roble.com>
To: ports@freebsd.org
Subject: Re: rc script problem - pidfile not being recognised
In-Reply-To: <20150911171930.59e67cc2@gumby.homeunix.com>
References: <20150911161850.402b3d5a@gumby.homeunix.com>
 <853047065.182.1441986957380.JavaMail.Kevin@Thoth>
 <20150911171930.59e67cc2@gumby.homeunix.com>
User-Agent: Alpine 2.11 (BSF 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Sep 2015 16:50:08 -0000

RW via freebsd-ports wrote:
> It needs both. It won't use just the pid file because the pid
> might have been reassigned to another process if the original daemon
> died without deleting its pid file.

Why would this rc script *require* a command_interpreter variable to use
the pidfile variable?  I'm curious because this violates KIS, the
principle of least surprise and few rc scripts seem to have this variable
defined.

Using command_interpreter is good to be sure, for for the reason listed,
but rc scripts should not fail if it is undefined.

IMO,
Roger Marquis