From owner-cvs-all@FreeBSD.ORG Thu Dec 23 15:29:15 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 1D55E16A4CE; Thu, 23 Dec 2004 15:29:15 +0000 (GMT) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.13.1/8.13.1) with ESMTP id iBNFTEE3015483; Thu, 23 Dec 2004 10:29:14 -0500 (EST) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.13.1/8.13.1/Submit) id iBNFT8CA015482; Thu, 23 Dec 2004 10:29:08 -0500 (EST) (envelope-from green) Date: Thu, 23 Dec 2004 10:29:08 -0500 From: Brian Fundakowski Feldman To: Paul Richards Message-ID: <20041223152908.GH41996@green.homeunix.org> References: <200412081116.iB8BGXw6057153@repoman.freebsd.org> <20041222233747.GA751@zaphod.nitro.dk> <20041223130719.GA786@myrddin.originative.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041223130719.GA786@myrddin.originative.co.uk> User-Agent: Mutt/1.5.6i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: "Simon L. Nielsen" cc: S?ren Schmidt Subject: Re: cvs commit: src/sys/dev/ata ata-queue.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Dec 2004 15:29:15 -0000 On Thu, Dec 23, 2004 at 01:07:19PM +0000, Paul Richards wrote: > On Thu, Dec 23, 2004 at 12:37:48AM +0100, Simon L. Nielsen wrote: > > On 2004.12.08 11:16:33 +0000, S?ren Schmidt wrote: > > > sos 2004-12-08 11:16:33 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/dev/ata ata-queue.c > > > Log: > > > Reset timeout when we are back from interrupt. > > > > > > Revision Changes Path > > > 1.41 +3 -0 src/sys/dev/ata/ata-queue.c > > > > This breaks my wonderful CDRW/DVD drive, which you have come to like > > so much. > > > > It fails to boot more or less like in the past with a memory modified > > after free. I don't have console output or trace, but i can get it if > > you need it. > > > > Let me know if you need me to test something. > > have separate CDRW and DVD and I saw this even before this patch, > I have atapi dma turned off because the machine won't boot and > throws the memory modified panics you describe otherwise. These are probably generic issues related to the detachment of drives at the wrong time (lifetime, queue synchronization, and timeout issues). I don't recall them ever actually being fixed, but I personally was not able to find and fix all of them, so I don't have much help to provide here. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\